Skip to content

feat: The exposed module reads the options.#112

Merged
killagu merged 2 commits intoeggjs:masterfrom
jiuhuan:feat/exposed-readModuleOptions
Apr 3, 2023
Merged

feat: The exposed module reads the options.#112
killagu merged 2 commits intoeggjs:masterfrom
jiuhuan:feat/exposed-readModuleOptions

Conversation

@jiuhuan
Copy link
Contributor

@jiuhuan jiuhuan commented Mar 31, 2023

暴露 readModuleOptions 配置,可用于扩展或过滤不需要的模块文件。

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a051b23) 92.97% compared to head (b7857b8) 92.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   92.97%   92.98%           
=======================================
  Files         217      217           
  Lines        4572     4574    +2     
  Branches      479      456   -23     
=======================================
+ Hits         4251     4253    +2     
  Misses        321      321           
Impacted Files Coverage Δ
core/common-util/src/ModuleConfig.ts 75.17% <100.00%> (+0.17%) ⬆️
plugin/config/app.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@SEWeiTung SEWeiTung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiuhuan : Thanks for the 1st contribution, and LGTM to me.

@SEWeiTung
Copy link

Waiting for the final @killagu 's check :)

Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiuhuan jiuhuan force-pushed the feat/exposed-readModuleOptions branch from 737b81a to b7857b8 Compare April 3, 2023 06:45
@killagu killagu added this pull request to the merge queue Apr 3, 2023
Merged via the queue into eggjs:master with commit a52b44b Apr 3, 2023
@killagu
Copy link
Contributor

killagu commented Apr 3, 2023

+3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants