test: use rolldown-vite for vitest #5541
Conversation
before
Test Files 208 passed | 17 skipped (225)
Tests 1564 passed | 210 skipped (1777)
Start at 23:22:56
Duration 29.70s (transform 31.81s, setup 0ms, collect 84.12s, tests 331.86s, environment 19ms, prepare 681ms)
after
Test Files 208 passed | 17 skipped (225)
Tests 1564 passed | 210 skipped (1777)
Start at 23:24:18
Duration 29.42s (transform 31.75s, setup 0ms, collect 81.94s, tests 329.88s, environment 18ms, prepare 674ms)
WalkthroughTest assertion in file_loader.test.ts broadened to match an additional syntax error message. Removed a devDependency from packages/supertest/package.json. Updated workspace configuration: bumped oxlint, added vite and rolldown-vite to minimumReleaseAgeExclude, and added an overrides mapping vite to npm:rolldown-vite@^7.1.13. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @fengmk2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the project's testing infrastructure by integrating Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the testing configuration to use rolldown-vite instead of standard Vite for Vitest builds, achieving similar test performance with slightly improved metrics. The change introduces a build tool override to leverage rolldown's faster compilation.
Key changes:
- Overrides Vite with rolldown-vite package for improved build performance
- Updates oxlint version to latest patch release
- Adjusts test error message patterns to accommodate rolldown's different syntax error reporting
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds rolldown-vite override configuration and updates oxlint version |
| packages/supertest/package.json | Removes unused @eggjs/bin development dependency |
| packages/core/test/loader/file_loader.test.ts | Updates error message regex to handle rolldown's syntax error format |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces vite with rolldown-vite for vitest across the workspace by using a pnpm override. The changes include updating a test to match new error messages and modifying dependency configurations. While the tests are passing, my main concern is the global nature of this override. It could affect other parts of the project that rely on vite, such as the documentation site build. I've added a comment to seek clarification on whether these areas have been tested.
Deploying egg with
|
| Latest commit: |
17aa703
|
| Status: | 🚫 Build failed. |
Deploying egg-v3 with
|
| Latest commit: |
17aa703
|
| Status: | 🚫 Build failed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #5541 +/- ##
==========================================
- Coverage 75.87% 75.56% -0.31%
==========================================
Files 114 114
Lines 5770 3999 -1771
Branches 1151 586 -565
==========================================
- Hits 4378 3022 -1356
+ Misses 1212 908 -304
+ Partials 180 69 -111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
packages/core/test/loader/file_loader.test.ts(1 hunks)packages/supertest/package.json(0 hunks)pnpm-workspace.yaml(2 hunks)
💤 Files with no reviewable changes (1)
- packages/supertest/package.json
🧰 Additional context used
📓 Path-based instructions (7)
pnpm-workspace.yaml
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Define dependency versions via the catalog section in pnpm-workspace.yaml and reference them with "catalog:"
Define and manage external dependency versions centrally in the catalog section of pnpm-workspace.yaml
Files:
pnpm-workspace.yaml
packages/**/test/**/*.test.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
packages/**/test/**/*.test.ts: Name test files as test/**/*.test.ts and run them with Vitest
Use import { describe, it } from 'vitest' in tests
Use Node.js built-in assert module for test assertions
Files:
packages/core/test/loader/file_loader.test.ts
**/*.ts
📄 CodeRabbit inference engine (AGENTS.md)
**/*.ts: Prefer TypeScript and ESM: write sources and exports in .ts (ESM-first) rather than CommonJS
Use two-space indentation, trailing commas, and semicolons (Prettier/oxlint defaults)
Name files in lowercase with hyphens (e.g., loader-context.ts)
Name classes in PascalCase
Name functions and variables in camelCase
Re-export types thoughtfully to keep the public API stable
Files:
packages/core/test/loader/file_loader.test.ts
**/test/**/*.test.ts
📄 CodeRabbit inference engine (AGENTS.md)
**/test/**/*.test.ts: Place test suites following Vitest discovery: /test//*.test.ts
Mirror the repository test pattern when adding new suites
Files:
packages/core/test/loader/file_loader.test.ts
{packages,plugins,tools,examples}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Enable TypeScript strict mode and follow TS best practices (explicit return types for public APIs, prefer interfaces over type aliases for object shapes, use readonly where appropriate, avoid any and use unknown when necessary)
Files:
packages/core/test/loader/file_loader.test.ts
{packages,plugins}/**/test/**/*.test.ts
📄 CodeRabbit inference engine (CLAUDE.md)
Vitest test files must follow the naming pattern test/**/*.test.ts and import test APIs from vitest with Node.js assert for assertions
Files:
packages/core/test/loader/file_loader.test.ts
{packages,plugins,tools}/**/test/**/*.test.ts
📄 CodeRabbit inference engine (CLAUDE.md)
All test files should live under test/ and be suffixed with .test.ts
Files:
packages/core/test/loader/file_loader.test.ts
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: eggjs/egg#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-25T15:21:16.381Z
Learning: Applies to {packages,plugins}/**/test/**/*.test.ts : Vitest test files must follow the naming pattern test/**/*.test.ts and import test APIs from vitest with Node.js assert for assertions
Learnt from: CR
PR: eggjs/egg#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-14T08:41:30.618Z
Learning: Applies to packages/**/test/**/*.test.ts : Name test files as test/**/*.test.ts and run them with Vitest
Learnt from: CR
PR: eggjs/egg#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-25T15:21:16.381Z
Learning: Applies to {packages,plugins}/**/vitest.config.ts : Each package (except egg-bin) must include a Vitest configuration file vitest.config.ts
Learnt from: CR
PR: eggjs/egg#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-14T08:41:30.618Z
Learning: Applies to packages/**/test/**/*.test.ts : Use Node.js built-in assert module for test assertions
Learnt from: CR
PR: eggjs/egg#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-14T08:41:30.618Z
Learning: Applies to packages/**/test/**/*.test.ts : Use import { describe, it } from 'vitest' in tests
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Test packages (macos-latest, 22)
- GitHub Check: Test egg-bin (ubuntu-latest, 22)
- GitHub Check: Test egg-bin (ubuntu-latest, 24)
- GitHub Check: Test packages (ubuntu-latest, 22)
- GitHub Check: Test packages (windows-latest, 24)
- GitHub Check: Test packages (windows-latest, 22)
- GitHub Check: Test packages (macos-latest, 24)
- GitHub Check: Cloudflare Pages: egg-v3
🔇 Additional comments (3)
pnpm-workspace.yaml (3)
130-130: LGTM: oxlint bump to ^1.18.0No concerns from me.
174-176: LGTM: added vite and rolldown-vite to minimumReleaseAgeExcludeAppropriate for fast‑moving toolchain packages.
177-178: Workspace-wide vite→rolldown-vite override safe
No package.json or source imports reference Vite—override won’t affect non-test packages. Optionally add rolldown-vite@^7.1.13 to the catalog for version centralization.
before
after
Summary by CodeRabbit
Tests
Chores