Skip to content

Commit c61a24c

Browse files
committed
Review changes
1 parent 14ad8a8 commit c61a24c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

packages/angular-material/src/other/master-detail/master.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ export class MasterListComponent extends JsonFormsArrayControl {
183183
const labelRefInstancePath = controlElement.options?.labelRef && removeSchemaKeywords(
184184
controlElement.options.labelRef
185185
);
186-
const isPrimitive = d && typeof d !== 'object';
186+
const isPrimitive = d !== undefined && typeof d !== 'object';
187187
const masterItem = {
188188
label: isPrimitive ? d.toString() : get(d, labelRefInstancePath ?? getFirstPrimitiveProp(schema)),
189189
data: d,

packages/examples/src/1779.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ const uischema = {
4545

4646
registerExamples([
4747
{
48-
name: '1779',
48+
name: '1779-string',
4949
label: 'List With Detail primitive (string)',
5050
data,
5151
schema,
@@ -74,8 +74,8 @@ const uischema_number = {
7474

7575
registerExamples([
7676
{
77-
name: '1779',
78-
label: 'List With Detail primitive (string)',
77+
name: '1779-number',
78+
label: 'List With Detail primitive (number)',
7979
data: data_number,
8080
schema: schema_number,
8181
uischema: uischema_number

0 commit comments

Comments
 (0)