Skip to content

Conversation

@angelozerr
Copy link
Contributor

OnEnterRules support for html files

Signed-off-by: azerr [email protected]

@mickaelistria
Copy link
Contributor

I think we need a CQ to allow inclusion of this language-configuration file. I created https://dev.eclipse.org/ipzilla/show_bug.cgi?id=24255

@angelozerr
Copy link
Contributor Author

Why we need not a CQ for JS/TS OnEnterRules file?

@mickaelistria
Copy link
Contributor

Why we need not a CQ for JS/TS OnEnterRules file?

We already had a CQ and approval for those when we included the language-configuration for the 1st time. The changes are then increments without strong IP matter, so no CQ required.

@angelozerr
Copy link
Contributor Author

angelozerr commented Sep 8, 2022

The language configuration for HTML already exists at https://github.com/eclipse/wildwebdeveloper/blob/master/org.eclipse.wildwebdeveloper/language-configurations/html/language-configuration.json

I have just renamed to language-configuration.jsonc (like I did for JST/TS) to avoid error with comments when you open it in Eclipse IDE.

@mickaelistria
Copy link
Contributor

Ah OK, my bad. So no need for a CQ indeed!

@mickaelistria mickaelistria merged commit 3703333 into eclipse-wildwebdeveloper:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants