Replacement of Program Launcher .ico in Product seems to be different from PDE

[phermsdorf]

Hi,

I'm building a product with and see a warning in the build log like this:
[WARNING] Icon path D:\workspace\dev\git\afs\customers.build\company\company.rcp.products\branding\ACM_launcher.ico does not exist and cannot be determined by Tycho, make sure that either the icon path is relative to the product file, or denotes a folder in the parent path of the product (current product path is D:\workspace\dev\git\afs\customers.build\company\company.rcp.products)
and the build product only has the default eclipse icon.

In the Product file i have configured the launcher .ico like this:

This is a path is relative to the products defining plugin.

This seems to be the same mechanism used for the definition on the Branding Tab for the windows images and About Dialog.

This works when started from the IDE and also in the build product, but of course i have no launcher icon when started from the IDE.

Changing to a relative path for the launcher icon, as suggested by the warning, works for the tycho build and the product launcher has the correct icon. But in the PDE editor i get a warning that the .ico file cannot be found ("the specified path points to a file that does not exist").

I suggest that tycho should also resolve the path relative to the products defining plugin.

Thanks for looking into the issue.

Bye Peter

Tycho 5.0.1
Eclipse 2025-09

[merks]

The Eclipse Installer is like this:

https://github.com/eclipse-oomph/oomph/blob/c747fcee8fe5b55d2d7d6e34f42e8a41e1981e50/products/org.eclipse.oomph.setup.installer.product/Installer.product#L33-L44

I.e., paths relative to the *.product file.

[phermsdorf]

Yes that works. That is also what the emitted warnings says. ("relative to the product")

Mhm, maybe it's just the point that when launching from the IDE the launcher .ico does not play a role at all.
When clicking on the File link before the icon a error pops up saying the .ico file could not be found.

So probably my assumption that the ico is resolved relative to the products defining plugin seems to be wrong ...

[merks]

For EPP it's like this:

https://github.com/eclipse-packaging/packages/blob/master/packages/org.eclipse.epp.package.committers.product/epp.product#L68-L80

[phermsdorf]

Thanks @merks for pointing this out.
Placing the launcher image next to the product definition works as expected.

My initial Use-Case was to just add a new .product definition but re-use all splash and branding configuration from the defining plugin, but that does not work at least for the launcher .ico. But not a big deal at all.

Bye Peter

[merks]

I see. EPP does share these across all the products.

[laeubi]

Launcher icon handling is quite fragile and inconsistent sometimes. We might be able to support more cases than today but current Tycho implementation covers the most usual cases.
The main problem is that a "product" not necessarily must be located inside a project nor does the "product defining plugin" be part of the reactor build at all.