[20310] Feature: topic keys with non breaking ABI #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for PKCS#11 in security files In addition to *.pem files containing the key or certificate, adds support for *.p11 files that contain the PKCS#11 URI of the key or certificate in an HSM. Signed-off-by: Iker Luengo <[email protected]> * linters Signed-off-by: Iker Luengo <[email protected]> Co-authored-by: Iker Luengo <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
…onstruction updates Signed-off-by: Mario Dominguez <[email protected]>
…ementation Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
…upport member Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
…eys() free function Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany
requested changes
Feb 14, 2024
Member
MiguelCompany
left a comment
MiguelCompany
left a comment
There was a problem hiding this comment.
Partial review: dynamic rmw pending
rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/TypeSupport.hpp
Outdated
Show resolved
Hide resolved
github-actions
bot
force-pushed
the
vulcanexus
branch
from
7e65f38 to
542c194
Compare
Signed-off-by: Mario Dominguez <[email protected]>
…to register the typesupport_introspection. This is useful when builtin types are also built with v2 abi and rmw_fastrtps_cpp is used Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany
requested changes
Feb 27, 2024
| // retrieve estimated serialized size in case key is unbounded | ||
| if (key_is_unbounded_) | ||
| { | ||
| key_max_serialized_size_ = (std::max) (key_callbacks_->get_serialized_size_key(ros_message, 0), (size_t)0); |
Member
There was a problem hiding this comment.
Suggested change
| key_max_serialized_size_ = (std::max) (key_callbacks_->get_serialized_size_key(ros_message, 0), (size_t)0); | |
| key_max_serialized_size_ = (std::max) ( | |
| key_max_serialized_size_, | |
| key_callbacks_->get_serialized_size_key(ros_message, 0)); |
Signed-off-by: Mario Dominguez <[email protected]>
github-actions
bot
force-pushed
the
vulcanexus
branch
from
542c194 to
487385e
Compare
…(no initial alignment) Signed-off-by: Mario Dominguez <[email protected]>
github-actions
bot
force-pushed
the
vulcanexus
branch
from
487385e to
0f2f12f
Compare
github-actions
bot
force-pushed
the
vulcanexus
branch
from
0f2f12f to
72e2282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the
topic keys featurewithout breakingABI. This means that the current version supports legacy message types of old generators thanks to a newtypesupport_identifierNote: This branch starts from the previous work on #19