Skip to content

Add get_first_untaken_info API [8062] #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 27, 2020
Merged

Add get_first_untaken_info API [8062] #1104

merged 4 commits into from
Mar 27, 2020

Conversation

@MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Mar 26, 2020 •
edited
Loading

This adds a new method on fastrtps::Subscriber to get information about the first untaken sample.

This is necessary in the context of ros2/rcl#591

@MiguelCompany
Copy link
Member Author

MiguelCompany commented Mar 26, 2020

@iluetkeb FYI

@MiguelCompany MiguelCompany added this to the v1.10.0 milestone Mar 26, 2020
@MiguelCompany MiguelCompany changed the title Add get_first_untaken_info API Add get_first_untaken_info API [8062] Mar 26, 2020
IkerLuengo
IkerLuengo approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Member

richiware commented Mar 26, 2020

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany merged commit d368993 into master Mar 27, 2020
@MiguelCompany MiguelCompany deleted the feature/get-next-sample-info branch March 27, 2020 06:47
@MiguelCompany MiguelCompany mentioned this pull request Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@IkerLuengo IkerLuengo IkerLuengo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@MiguelCompany @richiware @IkerLuengo