Skip to content

Commit 0fc148b

Browse files
nazar-pcbkchr
andauthored
Allow justifications on non-finalized blocks (paritytech#1211)
One assertion was unnecessary because of the check right above it, second assertion resolves paritytech#1159 --------- Co-authored-by: Bastian Köcher <[email protected]>
1 parent b031d1e commit 0fc148b

2 files changed

Lines changed: 0 additions & 3 deletions

File tree

substrate/client/consensus/grandpa/src/import.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,6 @@ where
552552
.into(),
553553
))
554554
}
555-
assert!(block.justifications.is_some());
556555
let mut authority_set = self.authority_set.inner_locked();
557556
authority_set.authority_set_changes.insert(number);
558557
crate::aux_schema::update_authority_set::<Block, _, _>(

substrate/client/service/src/client/client.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -603,8 +603,6 @@ where
603603
.block_gap
604604
.map_or(false, |(start, _)| *import_headers.post().number() == start);
605605

606-
assert!(justifications.is_some() && finalized || justifications.is_none() || gap_block);
607-
608606
// the block is lower than our last finalized block so it must revert
609607
// finality, refusing import.
610608
if status == blockchain::BlockStatus::Unknown &&

0 commit comments

Comments
 (0)