Remove NodeVisitor::DONT_TRAVERSE_* on ServerVariableToRequestFacadeRector (part 3) (#439)

* Remove NodeVisitor::DONT_TRAVERSE_* on ServerVariableToRequestFacadeRector (part 3)

* clean up set attribute

* clean up set node definiton

Author: samsonasik

src/Rector/ArrayDimFetch/ServerVariableToRequestFacadeRector.php

@@ -2,6 +2,7 @@
 
 namespace RectorLaravel\Rector\ArrayDimFetch;
 
+use Override;
 use PhpParser\Node;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr;
@@ -11,7 +12,6 @@
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Scalar\InterpolatedString;
 use PhpParser\Node\Stmt\Unset_;
-use PhpParser\NodeVisitor;
 use RectorLaravel\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -21,6 +21,8 @@
  */
 class ServerVariableToRequestFacadeRector extends AbstractRector
 {
+    private const string IS_IN_SERVER_VARIABLE = 'is_in_server_variable';
+
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
@@ -38,27 +40,41 @@ public function getRuleDefinition(): RuleDefinition
 
     public function getNodeTypes(): array
     {
-        return [Assign::class, Isset_::class, Unset_::class, InterpolatedString::class, ArrayDimFetch::class];
+        return [ArrayDimFetch::class];
     }
 
-    /**
-     * @param  ArrayDimFetch|Assign|Isset_|Unset_|InterpolatedString  $node
-     * @return StaticCall|NodeVisitor::DONT_TRAVERSE_CHILDREN|null
-     */
-    public function refactor(Node $node): StaticCall|int|null
+    #[Override]
+    public function beforeTraverse(array $nodes): array
     {
-        if (! $node instanceof ArrayDimFetch) {
-            if (! $node instanceof Assign) {
-                return NodeVisitor::DONT_TRAVERSE_CHILDREN;
-            }
+        parent::beforeTraverse($nodes);
+
+        $this->traverseNodesWithCallable($nodes, function (Node $node) {
+            if (in_array($node::class, [Assign::class, Isset_::class, Unset_::class, InterpolatedString::class], true)
+                    && (! $node instanceof Assign || $node->var instanceof ArrayDimFetch && $this->isName($node->var->var, '_SERVER'))) {
+                $this->traverseNodesWithCallable($node, function (Node $subNode) {
+                    if (! $subNode instanceof ArrayDimFetch) {
+                        return null;
+                    }
 
-            if (! $node->var instanceof ArrayDimFetch || ! $this->isName($node->var->var, '_SERVER')) {
-                return null;
+                    $subNode->setAttribute(self::IS_IN_SERVER_VARIABLE, true);
+
+                    return $subNode;
+                });
+
+                return $node;
             }
 
-            return NodeVisitor::DONT_TRAVERSE_CHILDREN;
-        }
+            return null;
+        });
 
+        return $nodes;
+    }
+
+    /**
+     * @param  ArrayDimFetch  $node
+     */
+    public function refactor(Node $node): ?StaticCall
+    {
         if (! $this->isName($node->var, '_SERVER')) {
             return null;
         }
@@ -67,6 +83,10 @@ public function refactor(Node $node): StaticCall|int|null
             return null;
         }
 
+        if ($node->getAttribute(self::IS_IN_SERVER_VARIABLE) === true) {
+            return null;
+        }
+
         return $this->nodeFactory->createStaticCall('Illuminate\Support\Facades\Request', 'server', [
             new Arg($node->dim),
         ]);