Skip to content

Conversation

@gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Sep 3, 2021

Signed-off-by: Gaius [email protected]

Description

  • Compatibility e2e with matrix.
  • Add test cases for image tag comparison.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.0 milestone Sep 3, 2021
@gaius-qi gaius-qi self-assigned this Sep 3, 2021
@gaius-qi gaius-qi requested review from a team as code owners September 3, 2021 03:16
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #599 (eb8c87b) into main (d2e70b2) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   38.56%   38.73%   +0.17%     
==========================================
  Files          87       87              
  Lines        6856     6856              
==========================================
+ Hits         2644     2656      +12     
+ Misses       3835     3824      -11     
+ Partials      377      376       -1     
Flag Coverage Δ
compatibility-e2etests ?
e2etests ?
unittests 38.73% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream_callback.go 64.55% <0.00%> (+2.53%) ⬆️
client/daemon/peer/peertask_stream.go 57.62% <0.00%> (+3.38%) ⬆️

Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
@jim3ma jim3ma merged commit 6ace52e into main Sep 3, 2021
@jim3ma jim3ma deleted the feature/compatibility-e2e branch September 3, 2021 07:24
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants