Skip to content

Commit 230131c

Browse files
committed
feat: remove lock for logger
Signed-off-by: santong <[email protected]>
1 parent ac9a444 commit 230131c

File tree

3 files changed

+0
-24
lines changed

3 files changed

+0
-24
lines changed

scheduler/supervisor/host.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -130,14 +130,6 @@ func (h *PeerHost) DecUploadLoad() int32 {
130130
}
131131

132132
func (h *PeerHost) Log() *logger.SugaredLoggerOnWith {
133-
h.lock.RLock()
134-
if h.logger != nil {
135-
h.lock.RUnlock()
136-
return h.logger
137-
}
138-
h.lock.RUnlock()
139-
h.lock.Lock()
140-
defer h.lock.Unlock()
141133
if h.logger == nil {
142134
h.logger = logger.WithTaskID(h.UUID)
143135
}

scheduler/supervisor/peer.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -344,14 +344,6 @@ func (peer *Peer) CloseChannel(err error) error {
344344
}
345345

346346
func (peer *Peer) Log() *logger.SugaredLoggerOnWith {
347-
peer.lock.RLock()
348-
if peer.logger != nil {
349-
peer.lock.RUnlock()
350-
return peer.logger
351-
}
352-
peer.lock.RUnlock()
353-
peer.lock.Lock()
354-
defer peer.lock.Unlock()
355347
if peer.logger == nil {
356348
peer.logger = logger.WithTaskID(peer.PeerID)
357349
}

scheduler/supervisor/task.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -298,14 +298,6 @@ func (task *Task) pick(limit int, reverse bool, pickFn func(peer *Peer) bool) (p
298298
}
299299

300300
func (task *Task) Log() *logger.SugaredLoggerOnWith {
301-
task.lock.RLock()
302-
if task.logger != nil {
303-
task.lock.RUnlock()
304-
return task.logger
305-
}
306-
task.lock.RUnlock()
307-
task.lock.Lock()
308-
defer task.lock.Unlock()
309301
if task.logger == nil {
310302
task.logger = logger.WithTaskID(task.TaskID)
311303
}

0 commit comments

Comments
 (0)