This repository was archived by the owner on Dec 20, 2024. It is now read-only.
fix: ineffective viper alias #903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
==========================================
+ Coverage 46.53% 46.58% +0.04%
==========================================
Files 114 114
Lines 6728 6730 +2
==========================================
+ Hits 3131 3135 +4
+ Misses 3343 3341 -2
Partials 254 254
Continue to review full report at Codecov.
|
starnop
reviewed
Sep 14, 2019
cmd/dfdaemon/app/root_test.go
Outdated
| r.Nil(err) | ||
| file.WriteString("supernodes:\n- 127.0.0.1:6666") | ||
| file.Close() | ||
| rootCmd.Flags().Set("config", configName) |
Contributor
There was a problem hiding this comment.
And could you please add more test cases:
- use config file that is not exist and specify the node with cli flag
- neither use config file and cli flag to specify the node and the expected result should be
127.0.0.1:8002
Member
Author
There was a problem hiding this comment.
Currently there's no default value for supernodes. Should we add one?
Collaborator
|
What' s the progress? Can we move on this because we really need to fix this bug as soon as possible |
Signed-off-by: inoc603 <[email protected]>
Member
Author
Collaborator
Contributor
|
LGTM. |
starnop
added a commit
to starnop/Dragonfly
that referenced
this pull request
Nov 27, 2019
fix: ineffective viper alias
inoc603
pushed a commit
to inoc603/Dragonfly
that referenced
this pull request
Dec 23, 2019
fix: ineffective viper alias
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
Signed-off-by: Jim Ma <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: inoc603 [email protected]
Ⅰ. Describe what this PR did
Remove
viper.RegisterAlias("supernodes", "node"), and set the value by hand.Ⅱ. Does this pull request fix one issue?
fixes #900
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
create a simple
dfdaemon.yml:First use the config file only:
Look for this line in log:
Then use the
--nodeflagAnd check the cli flag overrides the config file:
Ⅴ. Special notes for reviews