Skip to content
This repository was archived by the owner on Dec 20, 2024. It is now read-only.

Conversation

@zhouhao3
Copy link
Contributor

Signed-off-by: Zhou Hao [email protected]

Ⅰ. Describe what this PR did

Add util test for atomiccount,go.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

➜  atomiccount git:(add-util-test) go test -v atomiccount_test.go atomiccount.go
=== RUN   Test
OK: 2 passed
--- PASS: Test (0.00s)
PASS
ok      command-line-arguments  (cached)

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Contributor

We found this is your first time to contribute to Dragonfly, @q384566678
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

Codecov Report

Merging #1178 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
+ Coverage   47.47%   47.52%   +0.05%     
==========================================
  Files         113      114       +1     
  Lines        7193     7206      +13     
==========================================
+ Hits         3415     3425      +10     
- Misses       3505     3507       +2     
- Partials      273      274       +1
Impacted Files Coverage Δ
supernode/daemon/mgr/scheduler/manager.go 21.91% <0%> (-0.69%) ⬇️
pkg/atomiccount/atomiccount.go 84.61% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da94e78...0d6befb. Read the comment docs.

Signed-off-by: Zhou Hao <[email protected]>
Signed-off-by: Zhou Hao <[email protected]>
@lowzj lowzj changed the title Add util test for atomiccount test: add util test for atomiccount Jan 14, 2020
Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowzj lowzj merged commit def2b21 into dragonflyoss:master Jan 14, 2020
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants