Skip to content

Conversation

@jim3ma
Copy link
Member

@jim3ma jim3ma commented Sep 8, 2021

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner September 8, 2021 07:48
@jim3ma jim3ma force-pushed the feature/update-zh-docs branch from d31d9db to 3b7c1f3 Compare September 8, 2021 07:52
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #623 (3b7c1f3) into main (9797fac) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
+ Coverage   38.48%   38.54%   +0.05%     
==========================================
  Files          88       88              
  Lines        6969     6969              
==========================================
+ Hits         2682     2686       +4     
+ Misses       3908     3903       -5     
- Partials      379      380       +1     
Flag Coverage Δ
unittests 38.54% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 33.67% <0.00%> (-0.62%) ⬇️
client/daemon/peer/peertask_stream.go 57.92% <0.00%> (+2.26%) ⬆️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 985cccf into main Sep 8, 2021
@gaius-qi gaius-qi deleted the feature/update-zh-docs branch September 8, 2021 07:59
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants