Skip to content

Conversation

@gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Sep 8, 2021

Signed-off-by: Gaius [email protected]

Description

  • Add piece download timeout.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.0 milestone Sep 8, 2021
@gaius-qi gaius-qi self-assigned this Sep 8, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner September 8, 2021 05:55
@codecov-commenter
Copy link

Codecov Report

Merging #621 (028c630) into main (0569053) will decrease coverage by 0.11%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
- Coverage   38.51%   38.39%   -0.12%     
==========================================
  Files          88       88              
  Lines        6969     6969              
==========================================
- Hits         2684     2676       -8     
- Misses       3906     3914       +8     
  Partials      379      379              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 38.39% <40.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/config/peerhost.go 35.48% <ø> (ø)
client/daemon/daemon.go 0.00% <0.00%> (ø)
client/daemon/peer/piece_downloader.go 68.29% <100.00%> (ø)
client/daemon/peer/piece_manager.go 68.11% <100.00%> (+0.53%) ⬆️
client/daemon/peer/peertask_stream.go 55.66% <0.00%> (-1.62%) ⬇️
client/daemon/peer/peertask_base.go 33.06% <0.00%> (-0.62%) ⬇️

@jim3ma jim3ma merged commit 998bf20 into main Sep 8, 2021
@jim3ma jim3ma deleted the feature/piece-download-timeout branch September 8, 2021 07:38
gaius-qi added a commit that referenced this pull request Jun 28, 2023
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants