Skip to content

Conversation

@gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jul 5, 2022

Signed-off-by: Gaius [email protected]

Description

  • If service can not found fqdn, replace fqdn with hostname.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.5 milestone Jul 5, 2022
@gaius-qi gaius-qi self-assigned this Jul 5, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner July 5, 2022 07:38
@gaius-qi gaius-qi requested review from bergwolf, hyy0322 and zzy987 July 5, 2022 07:38
Copy link
Member

@KubeStacker KubeStacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1435 (5c724d2) into main (e45cdf5) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1435      +/-   ##
==========================================
- Coverage   44.48%   44.41%   -0.07%     
==========================================
  Files         113      113              
  Lines       10375    10379       +4     
==========================================
- Hits         4615     4610       -5     
- Misses       5297     5304       +7     
- Partials      463      465       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 44.41% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/net/fqdn/fqdn.go 33.33% <0.00%> (-26.67%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 45.45% <0.00%> (-2.17%) ⬇️

@gaius-qi gaius-qi merged commit bc3f245 into main Jul 5, 2022
@gaius-qi gaius-qi deleted the feature/fqdn branch July 5, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants