Skip to content

feat: seed peer add object storage port #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

feat: seed peer add object storage port #1408

merged 1 commit into from
Jun 23, 2022

Conversation

@gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jun 23, 2022

Signed-off-by: Gaius [email protected]

Description

  • Seed peer add object storage port.

Related Issue

#1249

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.4 milestone Jun 23, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner June 23, 2022 10:37
@gaius-qi gaius-qi requested review from bergwolf, eryugey and qwtsc June 23, 2022 10:37
@gaius-qi gaius-qi self-assigned this Jun 23, 2022
hyy0322
hyy0322 approved these changes Jun 23, 2022
View reviewed changes
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

KubeStacker
KubeStacker approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@KubeStacker KubeStacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KubeStacker KubeStacker merged commit 33d46ca into main Jun 23, 2022
@KubeStacker KubeStacker deleted the feature/object-storage-port branch June 23, 2022 11:23
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
feat: seed peer add object storage port (#1408)
5aa7e27 
Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyy0322 hyy0322 hyy0322 approved these changes

@bergwolf bergwolf Awaiting requested review from bergwolf bergwolf was automatically assigned from dragonflyoss/dragonfly-approvers

@qwtsc qwtsc Awaiting requested review from qwtsc qwtsc was automatically assigned from dragonflyoss/dragonfly-approvers

@eryugey eryugey Awaiting requested review from eryugey eryugey was automatically assigned from dragonflyoss/dragonfly-approvers

+1 more reviewer

@KubeStacker KubeStacker KubeStacker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gaius-qi gaius-qi

Labels

manager

Projects

None yet

Milestone

v2.0.4

Development

Successfully merging this pull request may close these issues.

4 participants

@gaius-qi @KubeStacker @hyy0322