Skip to content

fix: remove container after generating protoc#1306

Merged
anjia0532 merged 1 commit into
dragonflyoss:mainfrom
eryugey:protoc-fix
May 16, 2022
Merged

fix: remove container after generating protoc#1306
anjia0532 merged 1 commit into
dragonflyoss:mainfrom
eryugey:protoc-fix

Conversation

@eryugey
Copy link
Copy Markdown
Contributor

@eryugey eryugey commented May 15, 2022

Add '--rm' option to docker command, so container will be removed
automatically. Otherwise we'll have many exited but not removed
containers as we run 'make protoc'.

Signed-off-by: Eryu Guan [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Add '--rm' option to docker command, so container will be removed
automatically. Otherwise we'll have many exited but not removed
containers as we run 'make protoc'.

Signed-off-by: Eryu Guan <[email protected]>
@eryugey eryugey requested a review from a team as a code owner May 15, 2022 13:39
@eryugey eryugey requested review from 244372610, bergwolf and jim3ma May 15, 2022 13:39
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #1306 (1772f12) into main (845a6e1) will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
- Coverage   46.48%   46.12%   -0.36%     
==========================================
  Files         139      139              
  Lines       11716    11716              
==========================================
- Hits         5446     5404      -42     
- Misses       5680     5721      +41     
- Partials      590      591       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.12% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_piecetask_poller.go 30.43% <0.00%> (-16.67%) ⬇️
cdn/supervisor/progress/progress.go 90.62% <0.00%> (-6.25%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 42.56% <0.00%> (-2.57%) ⬇️
client/daemon/peer/peertask_conductor.go 57.84% <0.00%> (-0.73%) ⬇️
scheduler/service/service.go 82.77% <0.00%> (-0.64%) ⬇️

Copy link
Copy Markdown
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@anjia0532 anjia0532 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anjia0532 anjia0532 merged commit d601f95 into dragonflyoss:main May 16, 2022
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Add '--rm' option to docker command, so container will be removed
automatically. Otherwise we'll have many exited but not removed
containers as we run 'make protoc'.

Signed-off-by: Eryu Guan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants