fix: remove container after generating protoc#1306
Merged
Conversation
Add '--rm' option to docker command, so container will be removed automatically. Otherwise we'll have many exited but not removed containers as we run 'make protoc'. Signed-off-by: Eryu Guan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1306 +/- ##
==========================================
- Coverage 46.48% 46.12% -0.36%
==========================================
Files 139 139
Lines 11716 11716
==========================================
- Hits 5446 5404 -42
- Misses 5680 5721 +41
- Partials 590 591 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gaius-qi
pushed a commit
that referenced
this pull request
Jun 28, 2023
Add '--rm' option to docker command, so container will be removed automatically. Otherwise we'll have many exited but not removed containers as we run 'make protoc'. Signed-off-by: Eryu Guan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add '--rm' option to docker command, so container will be removed
automatically. Otherwise we'll have many exited but not removed
containers as we run 'make protoc'.
Signed-off-by: Eryu Guan [email protected]
Description
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist