Skip to content

chore: print client stream task error log #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

chore: print client stream task error log #1210

merged 1 commit into from
Mar 30, 2022

Conversation

@jim3ma
Copy link
Member

@jim3ma jim3ma commented Mar 30, 2022

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner March 30, 2022 08:34
@jim3ma jim3ma force-pushed the chore/print-client-stream-task-error-log branch from b3d3c30 to 43765ac Compare March 30, 2022 08:35
gaius-qi
gaius-qi approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit d2cf503 into main Mar 30, 2022
@jim3ma jim3ma deleted the chore/print-client-stream-task-error-log branch March 30, 2022 08:55
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@jim3ma @gaius-qi
chore: print client stream task error log (#1210)
60a1d9e 
Signed-off-by: Jim Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxxhero yxxhero yxxhero approved these changes

@gaius-qi gaius-qi gaius-qi approved these changes

@xujihui1985 xujihui1985 Awaiting requested review from xujihui1985 xujihui1985 was automatically assigned from dragonflyoss/dragonfly-approvers

@yangjun289519474 yangjun289519474 Awaiting requested review from yangjun289519474 yangjun289519474 was automatically assigned from dragonflyoss/dragonfly-approvers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jim3ma @yxxhero @gaius-qi