BrokerConnection receive bytes pipe #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
There's a test failure that needs further investigation |
dpkp
force-pushed
the
receive_bytes_pipe
branch
2 times, most recently
from
3e8d1a3 to
acd104d
Compare
dpkp
force-pushed
the
receive_bytes_pipe
branch
from
acd104d to
df227a6
Compare
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards #560 . Refactors the internals of BrokerConnection to separate handling network IO from decoding responses. The initial refactor only addresses recv . Refactoring send will be tackled in a separate PR. The eventual goal is to separate the base protocol parser into an isolated class that is completely independent of network IO.