Port DesignerAction*Collection components (#633)

* port DesignerActionListCollection

* port DesignerActionItemCollection

* PR comments

Author: JuditRose

src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionItemCollection.cs

@@ -10,38 +10,20 @@ public class DesignerActionItemCollection : CollectionBase
     {
         public DesignerActionItem this[int index]
         {
-            get => throw new NotImplementedException(SR.NotImplementedByDesign);
-            set => throw new NotImplementedException(SR.NotImplementedByDesign);
+            get => (DesignerActionItem)(List[index]);
+            set => List[index] = value;
         }
 
-        public int Add(DesignerActionItem value)
-        {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
-        }
-
-        public bool Contains(DesignerActionItem value)
-        {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
-        }
-
-        public void CopyTo(DesignerActionItem[] array, int index)
-        {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
-        }
+        public int Add(DesignerActionItem value) => List.Add(value);
 
-        public int IndexOf(DesignerActionItem value)
-        {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
-        }
+        public bool Contains(DesignerActionItem value) => List.Contains(value);
 
-        public void Insert(int index, DesignerActionItem value)
-        {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
-        }
+        public void CopyTo(DesignerActionItem[] array, int index) => List.CopyTo(array, index);
 
-        public void Remove(DesignerActionItem value)
-        {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
-        }
+        public int IndexOf(DesignerActionItem value) => List.IndexOf(value);
+        
+        public void Insert(int index, DesignerActionItem value) => List.Insert(index, value);
+        
+        public void Remove(DesignerActionItem value) => List.Remove(value);
     }
 }

src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionListCollection.cs

@@ -3,6 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 using System.Collections;
+using System.Diagnostics;
 using System.Runtime.InteropServices;
 
 namespace System.ComponentModel.Design
@@ -21,50 +22,50 @@ public DesignerActionListCollection(DesignerActionList[] value)
 
         public DesignerActionList this[int index]
         {
-            get => throw new NotImplementedException(SR.NotImplementedByDesign);
-            set => throw new NotImplementedException(SR.NotImplementedByDesign);
+            get => (DesignerActionList)(List[index]);
+            set => List[index] = value;
         }
 
         public int Add(DesignerActionList value)
         {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
+            return List.Add(value);
         }
 
         public void AddRange(DesignerActionList[] value)
         {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
+            if (value == null)
+            {
+                throw new ArgumentNullException(nameof(value));
+            }
+            for (int i = 0; i < value.Length; i++)
+            {
+                Add(value[i]);
+            }
         }
 
         public void AddRange(DesignerActionListCollection value)
         {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
-        }
-
-        public void Insert(int index, DesignerActionList value)
-        {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
-        }
-
-        public int IndexOf(DesignerActionList value)
-        {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
-        }
-
-        public bool Contains(DesignerActionList value)
-        {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
-        }
-
-        public void Remove(DesignerActionList value)
-        {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
-        }
-
-        public void CopyTo(DesignerActionList[] array, int index)
-        {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
-        }
-
+            if (value == null)
+            {
+                throw new ArgumentNullException(nameof(value));
+            }
+            int currentCount = value.Count;
+            for (int i = 0; i < currentCount; i++)
+            {
+                Add(value[i]);
+            }
+        }
+
+        public void Insert(int index, DesignerActionList value) => List.Insert(index, value);
+
+        public int IndexOf(DesignerActionList value) => List.IndexOf(value);
+        
+        public bool Contains(DesignerActionList value) => List.Contains(value);
+        
+        public void Remove(DesignerActionList value) => List.Remove(value);
+        
+        public void CopyTo(DesignerActionList[] array, int index) => List.CopyTo(array, index);
+        
         protected override void OnSet(int index, object oldValue, object newValue)
         {
         }
@@ -81,9 +82,6 @@ protected override void OnRemove(int index, object value)
         {
         }
 
-        protected override void OnValidate(object value)
-        {
-            throw new NotImplementedException(SR.NotImplementedByDesign);
-        }
+        protected override void OnValidate(object value) => Debug.Assert(value != null, "Don't add null actionlist!");
     }
 }

src/System.Windows.Forms.Design/tests/UnitTests/DesignerActionItemCollectionTests.cs

@@ -0,0 +1,68 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using System.ComponentModel.Design;
+using Xunit;
+
+namespace System.Windows.Forms.Design.Tests
+{
+    public class DesignerActionItemCollectionTests
+    {
+        [Fact]
+        public void DesignerActionItemCollection_Constructor()
+        {
+            DesignerActionItemCollection underTest = new DesignerActionItemCollection();
+            Assert.NotNull(underTest);
+            Assert.Empty(underTest);
+        }
+
+        [Fact]
+        public void DesignerActionItemCollection_Add_Contains_IndexOf()
+        {
+            DesignerActionItemCollection underTest = new DesignerActionItemCollection();
+
+            DesignerActionItem item1 = new DesignerActionItemTest("name", "category", "description");
+            underTest.Add(item1);
+            Assert.True(underTest.Contains(item1));
+            Assert.Equal(0, underTest.IndexOf(item1));
+
+            DesignerActionItem item2 = new DesignerActionItemTest("name1", "category1", "description1");
+            underTest.Add(item2);
+            Assert.True(underTest.Contains(item2));
+            Assert.Equal(1, underTest.IndexOf(item2));
+        }
+
+        [Fact]
+        public void DesignerActionItemCollection_Insert_Remove_Count()
+        {
+            DesignerActionItemCollection underTest = new DesignerActionItemCollection();
+            DesignerActionItem item1 = new DesignerActionItemTest("name", "category", "description");
+            DesignerActionItem item2 = new DesignerActionItemTest("name1", "category1", "description1");
+            DesignerActionItem item3 = new DesignerActionItemTest("name2", "category2", "description2");
+            DesignerActionItem item4 = new DesignerActionItemTest("name3", "category3", "description3");
+
+            underTest.Add(item1);
+            underTest.Add(item2);
+
+            underTest.Add(item3);
+            Assert.Equal(2, underTest.IndexOf(item3));
+
+            underTest.Insert(2, item4);
+            Assert.Equal(3, underTest.IndexOf(item3));
+            Assert.Equal(2, underTest.IndexOf(item4));
+
+            underTest.Remove(item4);
+            Assert.False(underTest.Contains(item4));
+            Assert.Equal(2, underTest.IndexOf(item3));
+            Assert.Equal(3, underTest.Count);
+        }
+
+        private class DesignerActionItemTest : DesignerActionItem
+        {
+            public DesignerActionItemTest(string displayName, string category, string description) : base(displayName, category, description)
+            {
+            }
+        }
+    }
+}

src/System.Windows.Forms.Design/tests/UnitTests/DesignerActionListCollectionTests.cs

@@ -0,0 +1,83 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using System.ComponentModel.Design;
+using WinForms.Common.Tests;
+using Xunit;
+
+namespace System.Windows.Forms.Design.Tests
+{
+    public class DesignerActionListCollectionTests
+    {
+        [Fact]
+        public void DesignerActionListCollection_Constructor()
+        {
+            DesignerActionListCollection underTest = new DesignerActionListCollection();
+            Assert.NotNull(underTest);
+        }
+
+        [Fact]
+        public void DesignerActionListCollection_Constructor_DesignerActionList()
+        {
+            DesignerActionListCollection underTest = CreateNewCollectionOfItems();
+            Assert.NotNull(underTest);
+        }
+
+        [Fact]
+        public void DesignerActionItemCollection_Add_AddRange()
+        {
+            DesignerActionListCollection underTest = CreateNewCollectionOfItems(5);
+            Assert.Equal(5, underTest.Count);
+
+            Button button = new Button();
+            DesignerActionList list = new DesignerActionList(button);
+            underTest.Add(list);
+            Assert.Equal(6, underTest.Count);
+
+            DesignerActionListCollection other = CreateNewCollectionOfItems(3);
+            underTest.AddRange(other);
+            Assert.Equal(9, underTest.Count);
+        }
+
+
+        [Fact]
+        public void DesignerActionItemCollection_Insert_Contains_IndexOf()
+        {
+            DesignerActionListCollection underTest = CreateNewCollectionOfItems(5);
+
+            Button button = new Button();
+            DesignerActionList list = new DesignerActionList(button);
+            underTest.Insert(3, list);
+            Assert.True(underTest.Contains(list));
+            Assert.Equal(3, underTest.IndexOf(list));
+        }
+
+        [Fact]
+        public void DesignerActionItemCollection_Remove()
+        {
+            DesignerActionListCollection underTest = CreateNewCollectionOfItems(5);
+
+            Button button = new Button();
+            DesignerActionList list = new DesignerActionList(button);
+            underTest.Insert(3, list);
+            underTest.Remove(list);
+            Assert.False(underTest.Contains(list));
+            Assert.Equal(5, underTest.Count);
+        }
+
+        private DesignerActionListCollection CreateNewCollectionOfItems(int numberOfItems = 1)
+        {
+            Button button = new Button();
+            DesignerActionList[] list = new DesignerActionList[] { new DesignerActionList(button) };
+            DesignerActionListCollection underTest = new DesignerActionListCollection(list);
+
+            for (int i = 1; i < numberOfItems; i++)
+            {
+                underTest.Add(new DesignerActionList(button));
+            }
+
+            return underTest;
+        }
+    }
+}