Merge | Port PR 499 to .NET Framework#3255
Merged
benrr101 merged 1 commit intodotnet:mainfrom Apr 7, 2025
Merged
Conversation
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3255 +/- ##
==========================================
- Coverage 72.69% 66.30% -6.39%
==========================================
Files 303 292 -11
Lines 59718 59324 -394
==========================================
- Hits 43414 39337 -4077
- Misses 16304 19987 +3683
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdaigle
approved these changes
Apr 3, 2025
Contributor
mdaigle
left a comment
There was a problem hiding this comment.
Looks like basically a 1:1 port and tests pass ✔️
benrr101
approved these changes
Apr 7, 2025
This was referenced Jul 25, 2025
Open
This was referenced Jan 15, 2026
This was referenced Jan 26, 2026
This was referenced Feb 2, 2026
This was referenced Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports #499 from netcore to netfx.
Relates to #1261.
Relates to #2965.
Once this PR is finished, the next PR which touches SqlDataReader will be able to merge it.
I'd appreciate a CI run of this please.