-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Merge ServicePoint assembly into Requests #94510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ServicePoint assembly into Requests #94510
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsPreparation for
|
src/libraries/shims/System.Net.ServicePoint/src/System.Net.ServicePoint.csproj
Outdated
Show resolved
Hide resolved
src/libraries/shims/System.Net.ServicePoint/src/System.Net.ServicePoint.csproj
Outdated
Show resolved
Hide resolved
…vicePoint.csproj Co-authored-by: Viktor Hofer <[email protected]>
|
/azp list |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Requests/src/System/Net/ServicePoint/BindIPEndPoint.cs
Outdated
Show resolved
Hide resolved
ViktorHofer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure that there aren't any any other hits of "System.Net.ServicePoint", i.e. in tests.proj.
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wfurt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM....but I'm not the expert. I would assume issues would surface via API compat or test failures.
|
Changes look good and APICompat ran successfully. Ready to go. |
|
CI Failures unrelated |
Preparation for
HttpWebRequest,ServicePoint, andServicePointManager's missing parts implementation.