Skip to content

Make JitPrintInlinedMethods less verbose #61208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 4 commits into from
Nov 6, 2021
Merged

Make JitPrintInlinedMethods less verbose #61208

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bed2117
Make JitPrintInlinedMethods less verbose
EgorBo Nov 4, 2021
659c389
Address feedback
EgorBo Nov 4, 2021
3ca405a
Address feedback
EgorBo Nov 4, 2021
5a2c5c2
SUCCESSFUL -> INLINED
EgorBo Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 32 additions & 26 deletions src/coreclr/jit/inline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,33 +386,53 @@ void InlineContext::Dump(unsigned indent)

mdMethodDef calleeToken = compiler->info.compCompHnd->getMethodDefFromMethod(m_Callee);

// Add more information when verbose mode or NgenDump/JitDump are set
bool verboseMode = (compiler->verbose) || (JitConfig.JitPrintInlinedMethodsVerbose() > 0);

// Dump this node
if (m_Parent == nullptr)
{
// Root method
InlinePolicy* policy = InlinePolicy::GetPolicy(compiler, true);
printf("Inlines into %08X [via %s] %s\n", calleeToken, policy->GetName(), calleeName);

if (verboseMode)
{
printf("\nInlines into %08X [via %s] %s:\n", calleeToken, policy->GetName(), calleeName);
}
else
{
printf("\nInlines into %s:\n", calleeName);
}
}
else
{
// Inline attempt.
const char* inlineTarget = InlGetTargetString(m_Observation);
const char* inlineReason = InlGetObservationString(m_Observation);
const char* inlineResult = m_Success ? "" : "FAILED: ";
const char* devirtualized = m_Devirtualized ? " devirt" : "";
const char* guarded = m_Guarded ? " guarded" : "";
const char* unboxed = m_Unboxed ? " unboxed" : "";
const char* inlineResult = m_Success ? "SUCCESSFUL: " : "FAILED: ";
const char* devirtualized = m_Devirtualized ? " DEVIRT" : "";
const char* guarded = m_Guarded ? " GUARDED" : "";
const char* unboxed = m_Unboxed ? " UNBOXED" : "";

if (m_Offset == BAD_IL_OFFSET)
if (verboseMode)
{
printf("%*s[%u IL=???? TR=%06u %08X] [%s%s: %s%s%s%s] %s\n", indent, "", m_Ordinal, m_TreeID, calleeToken,
inlineResult, inlineTarget, inlineReason, guarded, devirtualized, unboxed, calleeName);
if (m_Offset == BAD_IL_OFFSET)
{
printf("%*s[%u IL=???? TR=%06u %08X] [%s%s: %s%s%s%s] %s\n", indent, "", m_Ordinal, m_TreeID,
calleeToken, inlineResult, inlineTarget, inlineReason, guarded, devirtualized, unboxed,
calleeName);
}
else
{
printf("%*s[%u IL=%04d TR=%06u %08X] [%s%s: %s%s%s%s] %s\n", indent, "", m_Ordinal,
jitGetILoffs(m_Offset), m_TreeID, calleeToken, inlineResult, inlineTarget, inlineReason, guarded,
devirtualized, unboxed, calleeName);
}
}
else
{
IL_OFFSET offset = jitGetILoffs(m_Offset);
printf("%*s[%u IL=%04d TR=%06u %08X] [%s%s: %s%s%s%s] %s\n", indent, "", m_Ordinal, offset, m_TreeID,
calleeToken, inlineResult, inlineTarget, inlineReason, guarded, devirtualized, unboxed, calleeName);
printf("%*s[%s%s%s%s%s] %s\n", indent, "", inlineResult, inlineReason, guarded, devirtualized, unboxed,
calleeName);
}
}

Expand Down Expand Up @@ -763,21 +783,7 @@ void InlineResult::Report()

if ((m_Callee != nullptr) && (obs != InlineObservation::CALLEE_IS_NOINLINE))
{

#ifdef DEBUG

const char* obsString = InlGetObservationString(obs);

if (VERBOSE)
{
JITDUMP("\nINLINER: Marking %s as NOINLINE because of %s\n", callee, obsString);
}
else if (m_RootCompiler->fgPrintInlinedMethods)
{
printf("Marking %s as NOINLINE because of %s\n", callee, obsString);
}

#endif // DEBUG
JITDUMP("\nINLINER: Marking %s as NOINLINE because of %s\n", callee, InlGetObservationString(obs));

COMP_HANDLE comp = m_RootCompiler->info.compCompHnd;
comp->setMethodAttribs(m_Callee, CORINFO_FLG_BAD_INLINEE);
Expand Down
6 changes: 6 additions & 0 deletions src/coreclr/jit/jitconfigvalues.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,13 @@ CONFIG_INTEGER(JitQueryCurrentStaticFieldClass, W("JitQueryCurrentStaticFieldCla
CONFIG_INTEGER(JitReportFastTailCallDecisions, W("JitReportFastTailCallDecisions"), 0)
CONFIG_INTEGER(JitPInvokeCheckEnabled, W("JITPInvokeCheckEnabled"), 0)
CONFIG_INTEGER(JitPInvokeEnabled, W("JITPInvokeEnabled"), 1)

// Controls verbosity for JitPrintInlinedMethods. Ignored for JitDump/NgenDump where
// it's always set.
CONFIG_INTEGER(JitPrintInlinedMethodsVerbose, W("JitPrintInlinedMethodsVerboseLevel"), 0)
// Prints a tree of inlinees for a specific method (use '*' for all methods)
CONFIG_METHODSET(JitPrintInlinedMethods, W("JitPrintInlinedMethods"))

CONFIG_METHODSET(JitPrintDevirtualizedMethods, W("JitPrintDevirtualizedMethods"))
CONFIG_INTEGER(JitProfileChecks, W("JitProfileChecks"), 0) // 1 enable in dumps, 2 assert if issues found
CONFIG_INTEGER(JitRequired, W("JITRequired"), -1)
Expand Down