CI matrix change: debian+centos+sles #58988
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,6 @@ jobs: | |
| # Linux arm | ||
| - ${{ if eq(parameters.platform, 'Linux_arm') }}: | ||
| - ${{ if eq(parameters.jobParameters.isFullMatrix, true) }}: | ||
| - (Debian.11.Arm32.Open)[email protected]/dotnet-buildtools/prereqs:debian-11-helix-arm32v7-20210304164347-5a7c380 | ||
|
|
||
| # Linux arm64 | ||
|
|
@@ -57,7 +56,6 @@ jobs: | |
| - ${{ if and(eq(parameters.jobParameters.testScope, 'outerloop'), eq(parameters.jobParameters.runtimeFlavor, 'mono')) }}: | ||
| - (Centos.8.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:centos-8-helix-20201229003624-c1bf759 | ||
| - RedHat.7.Amd64.Open | ||
| - (Fedora.34.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-34-helix-20210728124700-4f64125 | ||
| - (Ubuntu.1910.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-19.10-helix-amd64-cfcfd50-20191030180623 | ||
| - (Debian.10.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:debian-10-helix-amd64-bfcd90a-20200121150006 | ||
|
|
@@ -67,21 +65,18 @@ jobs: | |
| - RedHat.7.Amd64.Open | ||
| - Ubuntu.1604.Amd64.Open | ||
| - Ubuntu.1804.Amd64.Open | ||
| - SLES.15.Amd64.Open | ||
| - (Fedora.34.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-34-helix-20210728124700-4f64125 | ||
| - (Ubuntu.1910.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-19.10-helix-amd64-cfcfd50-20191030180623 | ||
| - (Debian.11.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:debian-11-helix-amd64-20210304164428-5a7c380 | ||
| - (Mariner.1.0.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:cbl-mariner-1.0-helix-20210528192219-92bf620 | ||
| - ${{ if eq(parameters.jobParameters.isFullMatrix, false) }}: | ||
| - (Centos.8.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:centos-8-helix-20201229003624-c1bf759 | ||
| - RedHat.7.Amd64.Open | ||
| - (Debian.10.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:debian-10-helix-amd64-20210304164434-56c6673 | ||
| - Ubuntu.1604.Amd64.Open | ||
| - Ubuntu.1804.Amd64.Open | ||
|
Member
There was a problem hiding this comment. I would drop Ubuntu16, SLES and Fedora from the RedHat+CentOS+Debian+Ubuntu should be more than good enough coverage for the various Linux flavors. |
||
| - SLES.12.Amd64.Open | ||
| - (Fedora.34.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-34-helix-20210728124700-4f64125 | ||
| - ${{ if or(eq(parameters.jobParameters.interpreter, 'true'), eq(parameters.jobParameters.isSingleFile, true)) }}: | ||
| # Limiting interp runs as we don't need as much coverage. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
isFullMatrix==truebe a strict super set ofisFullMatrix==false?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've asked that in other PRs. That way we can track pass rate.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkotas This is game changer. If I understand correctly, we are not able to run test for PR only as Rolling tests will run all PR tests, is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it makes sense for PRs to run subset and for rolling to run everything (including the subset that PRs run).
I believe that it is the case today for the most part, there are just a few outliers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ViktorHofer, If I the a Debian 10 © as an example: We want this update:
Drop rolling (keep PR), was it meant to remove it only from isFullMatrix==true and leave it in isFullMatrix==false ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aik-jahoda based on the discussion above, we don't want to drop rolling anywhere except for EOL distros. So "Drop rolling (keep PR)" should probably be ignored.