From 18809eb4e9887e431425eb9b9dc558cfd2fafd63 Mon Sep 17 00:00:00 2001 From: Steve MacLean Date: Fri, 7 May 2021 15:18:37 -0400 Subject: [PATCH 1/2] Fix issue 42292 --- .../exception_handling/pal_sxs/test1/CMakeLists.txt | 4 ++++ src/coreclr/pal/tests/palsuite/issues.targets | 6 ------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/coreclr/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeLists.txt b/src/coreclr/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeLists.txt index 08de84f25e8de4..1df233fc68cd80 100644 --- a/src/coreclr/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeLists.txt +++ b/src/coreclr/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeLists.txt @@ -5,6 +5,10 @@ endif(CLR_CMAKE_HOST_UNIX) # Set the RPATH of paltest_pal_sxs_test1 so that it can find dependencies without needing to set LD_LIBRARY # For more information: http://www.cmake.org/Wiki/CMake_RPATH_handling. if(CORECLR_SET_RPATH) + if(CLR_CMAKE_HOST_OSX) + set(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE) + set(CMAKE_INSTALL_RPATH "@loader_path") + endif(CLR_CMAKE_HOST_OSX) if(CLR_CMAKE_HOST_LINUX) set(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE) set(CMAKE_INSTALL_RPATH "\$ORIGIN") diff --git a/src/coreclr/pal/tests/palsuite/issues.targets b/src/coreclr/pal/tests/palsuite/issues.targets index e5b4b245c178e9..bca854e409e9e9 100644 --- a/src/coreclr/pal/tests/palsuite/issues.targets +++ b/src/coreclr/pal/tests/palsuite/issues.targets @@ -28,18 +28,12 @@ https://github.com/dotnet/runtime/issues/7639 - - https://github.com/dotnet/runtime/issues/42292 - https://github.com/dotnet/runtime/issues/7639 - - https://github.com/dotnet/runtime/issues/42292 - https://github.com/dotnet/runtime/issues/42292 From 07cffd1e754b84d37922327cc5eb0995509b6647 Mon Sep 17 00:00:00 2001 From: Steve MacLean Date: Fri, 7 May 2021 15:19:13 -0400 Subject: [PATCH 2/2] Cleanup PAL issues.targets --- src/coreclr/pal/tests/palsuite/issues.targets | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/coreclr/pal/tests/palsuite/issues.targets b/src/coreclr/pal/tests/palsuite/issues.targets index bca854e409e9e9..6b0e8ae55667ad 100644 --- a/src/coreclr/pal/tests/palsuite/issues.targets +++ b/src/coreclr/pal/tests/palsuite/issues.targets @@ -24,23 +24,20 @@ - + https://github.com/dotnet/runtime/issues/7639 - - https://github.com/dotnet/runtime/issues/7639 - - https://github.com/dotnet/runtime/issues/42292 + https://github.com/dotnet/runtime/issues/48783 - https://github.com/dotnet/runtime/issues/7639 + https://github.com/dotnet/runtime/issues/48783