Fix Ilasm Round Trip script by adding retry logic #46765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
Contributor
Author
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fix bash syntax Update bash syntax to use while true
briansull
force-pushed
the
ilasm-roundtrip
branch
from
5d78799 to
dcae07b
Compare
Contributor
Author
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@BruceForstall PTAL |
BruceForstall
suggested changes
Jan 11, 2021
Contributor
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
looks great with just the one issue
| break | ||
| fi | ||
| echo Trying again | ||
| sleep 10 |
Contributor
There was a problem hiding this comment.
Looks like ilasm_count is never incremented.
| echo EXECUTION $ilasm_count OF ILASM - FAILED with $ERRORLEVEL | ||
| if [ $ilasm_count -eq 3 ] |
Contributor
There was a problem hiding this comment.
Maybe this should be a >= instead of ==? (is that -ge?)
BruceForstall
approved these changes
Jan 12, 2021
Contributor
Author
|
Updated with requested fix |
This was referenced Jan 12, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #44139