Skip to content

Make sure we treat the ptrs as unsigned #121221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
+20 −16
Draft

Make sure we treat the ptrs as unsigned #121221

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f1b1fd3
Make sure we treat tread the ptr as unsigned
lewing Oct 30, 2025
3ae2b93
fix streamed_response_bytes too
lewing Oct 30, 2025
8da5aae
Merge branch 'main' into sign-on-ptr
lewing Nov 1, 2025
cd94274
Add a few more defensive shifts
lewing Nov 7, 2025
5071584
Use fixupPointer
lewing Nov 7, 2025
38a0c4c
More defensive shifts
lewing Nov 7, 2025
ba7a1c0
remove the now redundant cast
lewing Nov 7, 2025
886a068
More fixups
lewing Nov 7, 2025
b7e33f5
Merge branch 'main' into sign-on-ptr
lewing Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/mono/browser/runtime/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export function http_wasm_transform_stream_write (controller: HttpController, bu
if (BuildConfiguration === "Debug") commonAsserts(controller);
mono_assert(bufferLength > 0, "expected bufferLength > 0");
// the bufferPtr is pinned by the caller
const view = new Span(bufferPtr, bufferLength, MemoryViewType.Byte);
const view = new Span(<any>((bufferPtr as any) >>> 0), bufferLength, MemoryViewType.Byte);
Copy link
Member

@pavelsavara pavelsavara Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rather do the conversion in _unsafe_create_view ?

const copy = view.slice() as Uint8Array;
return wrap_as_cancelable_promise(async () => {
mono_assert(controller.streamWriter, "expected streamWriter");
Expand Down Expand Up @@ -136,7 +136,7 @@ export function http_wasm_fetch_stream (controller: HttpController, url: string,
export function http_wasm_fetch_bytes (controller: HttpController, url: string, header_names: string[], header_values: string[], option_names: string[], option_values: any[], bodyPtr: VoidPtr, bodyLength: number): ControllablePromise<void> {
if (BuildConfiguration === "Debug") commonAsserts(controller);
// the bodyPtr is pinned by the caller
const view = new Span(bodyPtr, bodyLength, MemoryViewType.Byte);
const view = new Span(<any>((bodyPtr as any) >>> 0), bodyLength, MemoryViewType.Byte);
const copy = view.slice() as Uint8Array;
return http_wasm_fetch(controller, url, header_names, header_values, option_names, option_values, copy);
}
Expand Down Expand Up @@ -239,7 +239,7 @@ export function http_wasm_get_response_bytes (controller: HttpController, view:
export function http_wasm_get_streamed_response_bytes (controller: HttpController, bufferPtr: VoidPtr, bufferLength: number): ControllablePromise<number> {
if (BuildConfiguration === "Debug") commonAsserts(controller);
// the bufferPtr is pinned by the caller
const view = new Span(bufferPtr, bufferLength, MemoryViewType.Byte);
const view = new Span(<any>((bufferPtr as any) >>> 0), bufferLength, MemoryViewType.Byte);
return wrap_as_cancelable_promise(async () => {
await controller.responsePromise;
mono_assert(controller.response, "expected response");
Expand Down
Loading