-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[browser][coreCLR] async main, thread pool, timers #120976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+477
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Oct 22, 2025
src/native/libs/System.Native.Browser/libSystem.Native.Browser.footer.js
Show resolved
Hide resolved
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
3 tasks
Member
Author
|
is there more feedback ? |
jkotas
reviewed
Nov 3, 2025
jkotas
reviewed
Nov 3, 2025
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.NonBrowser.cs
Outdated
Show resolved
Hide resolved
…erServices/AsyncHelpers.NonBrowser.cs Co-authored-by: Aaron R Robinson <[email protected]>
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.NonBrowser.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.NonBrowser.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.NonBrowser.cs
Show resolved
Hide resolved
…erServices/AsyncHelpers.NonBrowser.cs Co-authored-by: Aaron R Robinson <[email protected]>
…erServices/AsyncHelpers.NonBrowser.cs Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
Co-authored-by: Aaron R Robinson <[email protected]>
gewarren
reviewed
Nov 3, 2025
Contributor
gewarren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some doc suggestions.
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.NonBrowser.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.NonBrowser.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Nov 3, 2025
Member
|
LGTM (the parts that I understand). Somebody with understanding of the JavaScript layer should review and signoff on that part. |
Co-authored-by: Jan Kotas <[email protected]>
maraf
approved these changes
Nov 4, 2025
radekdoulik
approved these changes
Nov 4, 2025
Member
Author
|
/ba-g CI timeouts and #114924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress:
-sEXIT_RUNTIME=0for coreRun toocoreclr_shutdown2_funcin coreRun/browserHostAsyncHelpers.Browser.cswithExecuteAsyncEntryPointthat would callSystemJS_RejectMainPromiseorSystemJS_ResolveMainPromiseAssembly::GetEntryPointto find original asyncMain()TaskAwaiter<int>.GetResult()which is not possible on ST browser.MemberLoader::FindMethodByNameby original name, but ignoring return typeValidateMainMethodto allow for signatures withTaskorTask<int>CorEntryPointType.EntryManagedMainAsyncandCorEntryPointType.EntryManagedMainAsyncVoidSystemJS_ExecuteTimerCallbackandSystemJS_ExecuteBackgroundJobCallback[UnmanagedCallersOnly]src\coreclr\vm\wasm\helpers.cppandsrc\coreclr\vm\corelib.hfor nowFixes #120212
Fixes #120211
Fixes #121046
This work with the PR
TODO
Task Main()of void signature.