-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Android] Support static linking of CoreCLR on Android #114629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
4243eb0
43310f2
4463fae
f08e9fe
ffa5351
8507f65
76b4d6a
2ef4399
1ff51f6
0584ea8
d6a2893
2b3a5ee
db2e108
39dea31
de2506e
1a12a79
7f282b6
2df2281
21b454f
d17fe7a
d53aefc
cd867ae
a9ac92c
e9d5b20
7b4efbf
ea53d06
4dc57cf
5e6cc7c
ed47a53
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,4 +26,4 @@ set (VXSORT_SOURCES | |
| do_vxsort.h | ||
| ) | ||
|
|
||
| add_library(gc_vxsort STATIC ${VXSORT_SOURCES}) | ||
| add_library(gc_vxsort OBJECT ${VXSORT_SOURCES}) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would be nice to use the same style, either this one in
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you mean to conditionally add gc_vxsort objects if android host?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That or change static to object in gc/unix as well.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added gc_vxsort_objects for the android host. I could also switch it from static to an object library, but I’m not sure if archive is actually being used in other scenarios.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need both, static and objects, for Android? If not, we can use an if-else block.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. BTW: vxsort is a ton of code for relatively small performance gain. We may want to disable it on mobile. It is implemented on x64 only for now, but arm64 implementation is in the works #110692 .
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Personally, I'd prefer to switch from static to object library here instead of introducing the conditional object for Android. At least for
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree. I haven’t applied these changes to the other libraries in this PR, since I’m not sure whether they’re required as archives on other platforms. |
||
Uh oh!
There was an error while loading. Please reload this page.