[release/8.0-staging] Revert "Avoid taking lock for empty bucket in ConcurrentDictionary.TryRemove …" #107656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yRemove …" This reverts commit 252018c.
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-collections |
leecow
added
Servicing-approved
4 tasks
carlossanlop
approved these changes
Sep 19, 2024
Contributor
|
/ba-g Failure is #87783 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107653 to release/8.0-staging
/cc @stephentoub
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
.NET 8: #82004
Testing
By the customer. There's a race condition that's hard to validate with a functional test.
Risk
Low. The change is trivial and is a pure revert of an optimization PR previously merged.