Skip to content

Provide System.Composition package readme #106443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2024
Merged

Provide System.Composition package readme #106443

merged 2 commits into from
Aug 20, 2024

Conversation

@eNeRGy164
Copy link
Contributor

@eNeRGy164 eNeRGy164 commented Aug 15, 2024

Fill out details for the System.Composition NuGet package readme.

See #99358

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 15, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Aug 15, 2024

Tagging subscribers to this area: @dotnet/area-system-composition
See info in area-owners.md if you want to be subscribed.

@ViktorHofer ViktorHofer mentioned this pull request Aug 15, 2024
Open
ViktorHofer
ViktorHofer reviewed Aug 15, 2024
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Composition is a meta package that brings in the other packages without providing an assembly. Should we have just one package readme for all the System.Composition packages or does it make sense to have a dedicated readme per Composition package?

ViktorHofer
ViktorHofer reviewed Aug 15, 2024
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Aug 15, 2024
Closed
@eNeRGy164
Copy link
Contributor Author

eNeRGy164 commented Aug 15, 2024

System.Composition is a meta package that brings in the other packages without providing an assembly. Should we have just one package readme for all the System.Composition packages or does it make sense to have a dedicated readme per Composition package?

For me, this is hard to judge. I also couldn't find another package that is similar and has a PACKAGE.md file.
I can imagine having different features highlighted per package. There has to be a reason why this was put is separate packages, right? 😝

@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 20, 2024

@dotnet/area-system-composition PTAL

buyaa-n
buyaa-n approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@buyaa-n buyaa-n merged commit a7c529c into dotnet:main Aug 20, 2024
@eNeRGy164 eNeRGy164 deleted the system-composition branch August 20, 2024 20:14
This was referenced Aug 21, 2024
Merged
Merged
Merged
Merged
Merged
buyaa-n pushed a commit to buyaa-n/runtime that referenced this pull request Sep 11, 2024
@eNeRGy164 @buyaa-n
Provide System.Composition package readme (dotnet#106443)
d64eace 
* Provide System.Composition package readme

* Fix empty lines
@buyaa-n buyaa-n mentioned this pull request Sep 11, 2024
Merged
4 tasks
carlossanlop pushed a commit that referenced this pull request Sep 12, 2024
@buyaa-n @eNeRGy164
[release/9.0] Backport some PACKAGE.md files (#107724)
bef9c4a 
* Provide System.Composition package readme (#106443)

* Provide System.Composition package readme

* Fix empty lines

* Provide System.Composition.AttributedModel package readme (#106781)

* Provide System.Composition.AttributedModel package readme

* Improve after feedback

* Set correct PackageDescription

* Provide System.Composition.Convention package readme (#106782)

* Provide System.Composition.Convention package readme

* Improve after feedback

* Provide System.Composition.Hosting package readme (#106783)

* Provide System.Composition.Hosting package readme

* Improve after feedback

* Provide System.Composition.Runtime package readme (#106784)

* Provide System.Composition.Runtime package readme

* Improve after feedback

* Provide System.Composition.TypedParts package readme (#106785)

* Provide System.Composition.TypedParts package readme

* Improve after feedback

* Provide System.CodeDom package readme (#107372)

* Provide System.CodeDom package readme

* Add remark about Roslyn/.NET Compiler SDK

* Update src/libraries/System.CodeDom/src/PACKAGE.md

---------

Co-authored-by: Buyaa Namnan <[email protected]>

---------

Co-authored-by: Michaël Hompus <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

+1 more reviewer

@buyaa-n buyaa-n buyaa-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Composition community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eNeRGy164 @ViktorHofer @buyaa-n