Skip to content

Conversation

@steveharter
Copy link
Contributor

Fixes #103542

Throw only on the (Type, String) ctor.

Copy link
Contributor

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steveharter
Copy link
Contributor Author

/ba-g Created new Quic issue for unrelated failure

@akoeplinger
Copy link
Member

akoeplinger commented Aug 1, 2024

This caused a test failure on dependency flow to sdk, please take a look: dotnet/sdk#42496 (comment)

I filed an issue and disabled the test temporarily: #105857

@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow DefaultValueAttribute with primitives when System.ComponentModel.DefaultValueAttribute.IsSupported disabled

4 participants