Fixed exception type for ConnectionShutdownInitiatedByTransport (#60244)

github-actions[bot] · ManickaP · web-flow · commit dcc4be529f69 · 2021-10-12T11:35:39.000-06:00
Co-authored-by: ManickaP &lt;mapichov@microsoft.com&gt;
diff --git a/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicConnection.cs b/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicConnection.cs
@@ -283,6 +283,11 @@ private static uint HandleEventShutdownInitiatedByTransport(State state, ref Con
                 state.ConnectTcs = null;
             }
 
+            // To throw QuicConnectionAbortedException (instead of QuicOperationAbortedException) out of AcceptStreamAsync() since
+            // it wasn't our side who shutdown the connection.
+            // We should rather keep the Status and propagate it either in a different exception or as a different field of QuicConnectionAbortedException.
+            // See: https://github.com/dotnet/runtime/issues/60133
+            state.AbortErrorCode = 0;
             state.AcceptQueue.Writer.TryComplete();
             return MsQuicStatusCodes.Success;
         }

Original file line number	Diff line number	Diff line change
`@@ -283,6 +283,11 @@ private static uint HandleEventShutdownInitiatedByTransport(State state, ref Con`
`283`	`283`	`state.ConnectTcs = null;`
`284`	`284`	`}`
`285`	`285`
	`286`	`+ // To throw QuicConnectionAbortedException (instead of QuicOperationAbortedException) out of AcceptStreamAsync() since`
	`287`	`+ // it wasn't our side who shutdown the connection.`
	`288`	`+ // We should rather keep the Status and propagate it either in a different exception or as a different field of QuicConnectionAbortedException.`
	`289`	`+ // See: https://github.com/dotnet/runtime/issues/60133`
	`290`	`+ state.AbortErrorCode = 0;`
`286`	`291`	`state.AcceptQueue.Writer.TryComplete();`
`287`	`292`	`return MsQuicStatusCodes.Success;`
`288`	`293`	`}`