Skip to content

Commit d59bfff

Browse files
authored
[wasm] Replace active issue for browser platform with NodeJS only (#65505)
1 parent 89e5469 commit d59bfff

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/libraries/System.Net.WebSockets.Client/tests/AbortTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public AbortTest(ITestOutputHelper output) : base(output) { }
1717

1818
[OuterLoop("Uses external servers", typeof(PlatformDetection), nameof(PlatformDetection.LocalEchoServerIsNotAvailable))]
1919
[ConditionalTheory(nameof(WebSocketsSupported)), MemberData(nameof(EchoServers))]
20-
[ActiveIssue("https://github.com/dotnet/runtime/issues/63673", TestPlatforms.Browser)]
20+
[ActiveIssue("https://github.com/dotnet/runtime/issues/63673", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
2121
public async Task Abort_ConnectAndAbort_ThrowsWebSocketExceptionWithmessage(Uri server)
2222
{
2323
using (var cws = new ClientWebSocket())

src/libraries/System.Net.WebSockets.Client/tests/ConnectTest.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ public async Task ConnectAsync_CookieHeaders_Success(Uri server)
170170

171171
[OuterLoop("Uses external servers", typeof(PlatformDetection), nameof(PlatformDetection.LocalEchoServerIsNotAvailable))]
172172
[ConditionalTheory(nameof(WebSocketsSupported)), MemberData(nameof(EchoServers))]
173-
[ActiveIssue("https://github.com/dotnet/runtime/issues/63681", TestPlatforms.Browser)]
173+
[ActiveIssue("https://github.com/dotnet/runtime/issues/63681", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
174174
public async Task ConnectAsync_PassNoSubProtocol_ServerRequires_ThrowsWebSocketException(Uri server)
175175
{
176176
const string AcceptedProtocol = "CustomProtocol";
@@ -257,7 +257,7 @@ public async Task ConnectAndCloseAsync_UseProxyServer_ExpectedClosedState(Uri se
257257
}
258258

259259
[ConditionalFact(nameof(WebSocketsSupported))]
260-
[ActiveIssue("https://github.com/dotnet/runtime/issues/63672", TestPlatforms.Browser)]
260+
[ActiveIssue("https://github.com/dotnet/runtime/issues/63672", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
261261
public async Task ConnectAsync_CancellationRequestedBeforeConnect_ThrowsOperationCanceledException()
262262
{
263263
using (var clientSocket = new ClientWebSocket())
@@ -270,7 +270,7 @@ public async Task ConnectAsync_CancellationRequestedBeforeConnect_ThrowsOperatio
270270
}
271271

272272
[ConditionalFact(nameof(WebSocketsSupported))]
273-
[ActiveIssue("https://github.com/dotnet/runtime/issues/63672", TestPlatforms.Browser)]
273+
[ActiveIssue("https://github.com/dotnet/runtime/issues/63672", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
274274
public async Task ConnectAsync_CancellationRequestedInflightConnect_ThrowsOperationCanceledException()
275275
{
276276
using (var clientSocket = new ClientWebSocket())
@@ -284,7 +284,7 @@ public async Task ConnectAsync_CancellationRequestedInflightConnect_ThrowsOperat
284284

285285
[ConditionalFact(nameof(WebSocketsSupported))]
286286
[ActiveIssue("https://github.com/dotnet/runtime/issues/34690", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
287-
[ActiveIssue("https://github.com/dotnet/runtime/issues/63671", TestPlatforms.Browser)]
287+
[ActiveIssue("https://github.com/dotnet/runtime/issues/63671", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
288288
public async Task ConnectAsync_CancellationRequestedAfterConnect_ThrowsOperationCanceledException()
289289
{
290290
var releaseServer = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

0 commit comments

Comments
 (0)