Skip to content

Commit c55578b

Browse files
Copilotstephentoub
andauthored
Replace outdated Array.Empty comments with correct reason (#123862)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>
1 parent 8acd159 commit c55578b

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

src/libraries/System.Collections.Immutable/src/System/Collections/Immutable/ImmutableArray_1.Minimal.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ public partial struct ImmutableArray<T> : IEnumerable<T>, IEquatable<ImmutableAr
3939
/// An empty (initialized) instance of <see cref="ImmutableArray{T}"/>.
4040
/// </summary>
4141
#pragma warning disable CA1825
42-
// Array.Empty<T>() doesn't exist in all configurations
43-
// Switching to Array.Empty also has a non-negligible impact on the working set memory
42+
// Avoid the extra generic instantiation for Array.Empty<T>()
4443
public static readonly ImmutableArray<T> Empty = new ImmutableArray<T>(new T[0]);
4544
#pragma warning restore CA1825
4645

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ internal ActivityChangedEventArgs(Activity? previous, Activity? current)
5858
[DebuggerTypeProxy(typeof(ActivityDebuggerProxy))]
5959
public partial class Activity : IDisposable
6060
{
61-
#pragma warning disable CA1825 // Array.Empty<T>() doesn't exist in all configurations
61+
#pragma warning disable CA1825 // avoid the extra generic instantiation for Array.Empty<T>()
6262
private static readonly IEnumerable<KeyValuePair<string, string?>> s_emptyBaggageTags = new KeyValuePair<string, string?>[0];
6363
private static readonly IEnumerable<KeyValuePair<string, object?>> s_emptyTagObjects = new KeyValuePair<string, object?>[0];
6464
private static readonly IEnumerable<ActivityLink> s_emptyLinks = new DiagLinkedList<ActivityLink>();

src/libraries/System.Threading.Tasks.Dataflow/src/Internal/ImmutableArray.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ namespace System.Threading.Tasks.Dataflow.Internal
2525
internal readonly struct ImmutableArray<T>
2626
{
2727
/// <summary>An empty array.</summary>
28-
#pragma warning disable CA1825 // Array.Empty<T>() doesn't exist in all configurations
28+
#pragma warning disable CA1825 // avoid the extra generic instantiation for Array.Empty<T>()
2929
private static readonly ImmutableArray<T> s_empty = new ImmutableArray<T>(new T[0]);
3030
#pragma warning restore CA1825
3131
/// <summary>The immutable data in this array instance.</summary>

0 commit comments

Comments
 (0)