Skip to content

Commit bb6923e

Browse files
committed
Enable Helix tests to run record-trace
1 parent 9009189 commit bb6923e

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

src/tests/Common/helixpublishwitharcade.proj

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -458,6 +458,20 @@
458458
</ItemGroup>
459459

460460
<Copy UseHardlinksIfPossible="true" SourceFiles="@(ReducedMergedPayloadFilesFinal)" DestinationFiles="@(ReducedMergedPayloadFilesFinal->'$(MergedPayloadsRootDirectory)\$(_MergedWrapperName)\%(FileRelativeToPayloadsRootDirectory)')" Condition="'@(ReducedMergedPayloadFilesFinal)' != ''" />
461+
462+
<ItemGroup>
463+
<_ExtraExecutableListFiles Include="@(_MergedPayloadFiles)"
464+
Condition="$([System.String]::Copy('%(Identity)').ToLower().EndsWith('helix-extra-executables.list'))" />
465+
<_ExtraExecutables Remove="@(_ExtraExecutables)" />
466+
</ItemGroup>
467+
<ReadLinesFromFile File="%(_ExtraExecutableListFiles.Identity)" Condition="'@(_ExtraExecutableListFiles)' != ''">
468+
<Output TaskParameter="Lines" ItemName="_ExtraExecutables" />
469+
</ReadLinesFromFile>
470+
<ItemGroup>
471+
<_ExtraExecutables Remove="@(_ExtraExecutables)" Condition="'%(Identity)' == ''" />
472+
<HelixCommandLines Condition="'$(TestWrapperTargetsWindows)' != 'true' and Exists('$(MergedPayloadsRootDirectory)\$(_MergedWrapperName)\%(Identity)')" Include="@(_ExtraExecutables->'chmod +x %(Identity)')" />
473+
</ItemGroup>
474+
461475
<WriteLinesToFile File="$(MergedPayloadsRootDirectory)\$(_MergedWrapperName)\HelixCommand.txt" Lines="@(HelixCommandLines)" />
462476
</Target>
463477

src/tests/tracing/eventpipe/userevents/userevents.csproj

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,16 @@
2727
<_DestDir>$(TargetDir)</_DestDir>
2828
<_DestDir Condition="'$(_DestDir)' == ''">$(OutputPath)</_DestDir>
2929
<_RecordTraceSource>$(NuGetPackageRoot)microsoft.onecollect.recordtrace/$(MicrosoftOneCollectRecordTraceVersion)/runtimes/linux-$(TargetArchitecture)/native/record-trace</_RecordTraceSource>
30+
<_RecordTraceRelative Condition="$(BuildProjectRelativeDir) != ''">$(BuildProjectRelativeDir)record-trace</_RecordTraceRelative>
31+
<_RecordTraceRelative Condition="'$(_RecordTraceRelative)' == ''">$([System.IO.Path]::GetRelativePath('$(TestBinDir)', '$(_DestDir)record-trace'))</_RecordTraceRelative>
3032
</PropertyGroup>
3133

3234
<Copy SourceFiles="$(_RecordTraceSource)" DestinationFiles="$(_DestDir)record-trace" SkipUnchangedFiles="true" />
35+
36+
<!-- For local testing, ensure it has execute permissions -->
3337
<Exec Command="chmod +x '$(_DestDir)record-trace'" Condition="Exists('$(_DestDir)record-trace')" />
38+
39+
<!-- For Helix builds, artifacts copied over have their permissions reset. Add the executable to a list for helix to reapply execute permissions -->
40+
<WriteLinesToFile File="$(_DestDir)helix-extra-executables.list" Lines="$(_RecordTraceRelative)" Overwrite="true" />
3441
</Target>
3542
</Project>

0 commit comments

Comments
 (0)