Eliminated info creation for non-public properties (#2278)

YohDeadfall · web-flow · commit 7c38fc942f14 · 2020-02-02T11:56:18.000-08:00
diff --git a/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonClassInfo.cs b/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonClassInfo.cs
@@ -138,7 +138,7 @@ public JsonClassInfo(Type type, JsonSerializerOptions options)
                     {
                         CreateObject = options.MemberAccessorStrategy.CreateConstructor(type);
 
-                        PropertyInfo[] properties = type.GetProperties(BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic);
+                        PropertyInfo[] properties = type.GetProperties(BindingFlags.Instance | BindingFlags.Public);
 
                         Dictionary<string, JsonPropertyInfo> cache = CreatePropertyCache(properties.Length);
 

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ public JsonClassInfo(Type type, JsonSerializerOptions options)`
`138`	`138`	`{`
`139`	`139`	`CreateObject = options.MemberAccessorStrategy.CreateConstructor(type);`
`140`	`140`
`141`		`- PropertyInfo[] properties = type.GetProperties(BindingFlags.Instance \| BindingFlags.Public \| BindingFlags.NonPublic);`
	`141`	`+ PropertyInfo[] properties = type.GetProperties(BindingFlags.Instance \| BindingFlags.Public);`
`142`	`142`
`143`	`143`	`Dictionary<string, JsonPropertyInfo> cache = CreatePropertyCache(properties.Length);`
`144`	`144`