Skip to content

Commit 615224c

Browse files
authored
Fix policheck warnings (#65179)
1 parent 5861bd9 commit 615224c

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

src/coreclr/nativeaot/Runtime/EHHelpers.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ EXTERN_C int32_t __stdcall RhpPInvokeExceptionGuard(PEXCEPTION_RECORD pExc
195195

196196
// If the thread is currently in the "do not trigger GC" mode, we must not allocate, we must not reverse pinvoke, or
197197
// return from a pinvoke. All of these things will deadlock with the GC and they all become increasingly likely as
198-
// exception dispatch kicks off. So we just nip this in the bud as early as possible with a FailFast. The most
198+
// exception dispatch kicks off. So we just address this as early as possible with a FailFast. The most
199199
// likely case where this occurs is in our GC-callouts for Jupiter lifetime management -- in that case, we have
200200
// managed code that calls to native code (without pinvoking) which might have a bug that causes an AV.
201201
if (pThread->IsDoNotTriggerGcSet())

src/coreclr/nativeaot/Runtime/eventtrace.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2496,8 +2496,8 @@ void ETW::TypeSystemLog::SendObjectAllocatedEvent(Object* pObject)
24962496
// over 10K in size.
24972497
if (size < 10000 && typeLoggingInfo.dwAllocsSkippedForSample < typeLoggingInfo.dwAllocsToSkipPerSample)
24982498
{
2499-
// Update hash table's copy of type logging info with these values. Sucks that
2500-
// we're doing another hash table lookup here. Could instead have used LookupPtr()
2499+
// Update hash table's copy of type logging info with these values. Unfortunate that
2500+
// we're doing another hash table lookup here. Could instead have used LookupPtr()
25012501
// if it gave us back a non-const pointer, and then we could have updated in-place
25022502
AddOrReplaceTypeLoggingInfo(pLoggedTypesFromModule, &typeLoggingInfo);
25032503
if (fCreatedNew)

src/coreclr/nativeaot/System.Private.Reflection.Core/src/System/Reflection/Runtime/BindingFlagSupport/MethodPolicies.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public sealed override void GetMemberAttributes(MethodInfo member, out MethodAtt
3838

3939
public sealed override bool ImplicitlyOverrides(MethodInfo baseMember, MethodInfo derivedMember)
4040
{
41-
// TODO (https://github.com/dotnet/corert/issues/1896) Comparing signatures is lame. The runtime and/or toolchain should have a way of sharing this info.
41+
// TODO (https://github.com/dotnet/corert/issues/1896) Comparing signatures is fragile. The runtime and/or toolchain should have a way of sharing this info.
4242
return AreNamesAndSignaturesEqual(baseMember, derivedMember);
4343
}
4444

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/CompilerTypeSystemContext.BoxedTypes.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ public BoxedValueType(ModuleDesc owningModule, MetadataType valuetype)
278278
{
279279
// BoxedValueType has the same genericness as the valuetype it's wrapping.
280280
// Making BoxedValueType wrap the genericness (and be itself nongeneric) would
281-
// require a crazy name mangling scheme to allow generating stable and unique names
281+
// require a name mangling scheme to allow generating stable and unique names
282282
// for the wrappers.
283283
Debug.Assert(valuetype.IsTypeDefinition);
284284

@@ -390,7 +390,7 @@ public GenericUnboxingThunk(BoxedValueType owningType, MethodDesc targetMethod)
390390
{
391391
Debug.Assert(targetMethod.OwningType.IsValueType);
392392
Debug.Assert(!targetMethod.Signature.IsStatic);
393-
393+
394394
_owningType = owningType;
395395
_targetMethod = targetMethod;
396396
_nakedTargetMethod = new ValueTypeInstanceMethodWithHiddenParameter(targetMethod);
@@ -574,7 +574,7 @@ public ValueTypeInstanceMethodWithHiddenParameter(MethodDesc methodRepresented)
574574
{
575575
Debug.Assert(methodRepresented.OwningType.IsValueType);
576576
Debug.Assert(!methodRepresented.Signature.IsStatic);
577-
577+
578578
_methodRepresented = methodRepresented;
579579
}
580580

0 commit comments

Comments
 (0)