Skip to content

Commit 5c6f5b1

Browse files
authored
Fix signing in PR runs (#31926)
Make URCT copying unconditional to unblock installer tasks in debug mode. Thanks Tomas
1 parent a4bc93f commit 5c6f5b1

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

eng/pipelines/installer/jobs/base-job.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,8 @@ jobs:
6868
eq(parameters.isOfficialBuild, true),
6969
ne(parameters.crossrootfsDir, '')) }}
7070

71-
# TODO: (Consolidation) Enable test signing during PR validation. https://github.com/dotnet/runtime/issues/1026
72-
#
73-
# CoreCLR only produces the UCRT redist file in Release config. When the redist file isn't
74-
# present, signing fails. For now, only sign in official builds which only run Release mode.
7571
- name: SignType
76-
value: ''
72+
value: test
7773

7874
# Set up non-PR build from internal project
7975
- ${{ if eq(parameters.isOfficialBuild, true) }}:

src/coreclr/src/build.proj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<UcrtFilesToCopy Include="$(UniversalCRTSDKDir)Redist\ucrt\DLLs\$(BuildArch)\*.dll" />
2121
</ItemGroup>
2222

23-
<Copy Condition="'$(BuildType)'=='Release' AND '$(BuildArch)' != 'arm64'"
23+
<Copy Condition="'$(BuildArch)' != 'arm64'"
2424
SourceFiles="@(UcrtFilesToCopy)"
2525
DestinationFolder="$(BinDir)Redist\ucrt\DLLs\$(BuildArch)" />
2626
</Target>

0 commit comments

Comments
 (0)