Skip to content

Commit 44366ae

Browse files
committed
Review feedback.
1 parent 9875a37 commit 44366ae

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/coreclr/utilcode/log.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,6 @@ VOID LogSpewAlwaysValist(const char *fmt, va_list args)
373373
if (LogFlags & LOG_ENABLE_CONSOLE_LOGGING)
374374
{
375375
minipal_log_write_info(pBuffer);
376-
//<TODO>@TODO ...Unnecessary to flush console?</TODO>
377376
if (LogFlags & LOG_ENABLE_FLUSH_FILE)
378377
minipal_log_sync_info();
379378
}

src/coreclr/vm/eepolicy.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ void LogInfoForFatalError(UINT exitCode, LPCWSTR pszMessage, PEXCEPTION_POINTERS
373373

374374
EX_TRY
375375
{
376-
SString message;
376+
StackSString message;
377377
if (exitCode == (UINT)COR_E_FAILFAST)
378378
{
379379
message.Append(W("Process terminated. "));
@@ -387,6 +387,10 @@ void LogInfoForFatalError(UINT exitCode, LPCWSTR pszMessage, PEXCEPTION_POINTERS
387387
{
388388
message.Append(errorSource);
389389
message.Append(W("\n"));
390+
391+
PrintToStdErrW(message.GetUnicode());
392+
393+
message.Clear();
390394
}
391395

392396
if (pszMessage != NULL)
@@ -396,7 +400,7 @@ void LogInfoForFatalError(UINT exitCode, LPCWSTR pszMessage, PEXCEPTION_POINTERS
396400
else
397401
{
398402
// If no message was passed in, generate it from the exitCode
399-
SString exitCodeMessage;
403+
InlineSString<256> exitCodeMessage;
400404
GetHRMsg(exitCode, exitCodeMessage);
401405
message.Append(exitCodeMessage);
402406
}

0 commit comments

Comments
 (0)