Skip to content

Commit 0c39507

Browse files
authored
Work around -no_weak_imports issue with recent Xcode (#36436)
See mono/mono#19393. We can use the `-Werror=partial-availability` as a good alternative until the Xcode bug is fixed.
1 parent c711920 commit 0c39507

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/mono/mono.proj

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@
134134
<_MonoCFLAGS Condition="'$(Platform)' == 'arm64'" Include="-arch arm64" />
135135
<_MonoCFLAGS Include="-isysroot $(XcodeDir)/Platforms/AppleTVOS.platform/Developer/SDKs/AppleTVOS$(tvOSVersion).sdk" />
136136
<_MonoCFLAGS Include="-mtvos-version-min=$(tvOSVersionMin)" />
137+
<_MonoCFLAGS Include="-Werror=partial-availability" />
137138
<_MonoCFLAGS Include="-Wl,-application_extension" />
138139
<_MonoCFLAGS Include="-fexceptions" />
139140
<_MonoCFLAGS Include="-fembed-bitcode" />
@@ -158,7 +159,7 @@
158159
<_MonoCPPFLAGS Include="-DHAVE_LARGE_FILE_SUPPORT=1" />
159160

160161
<_MonoLDFLAGS Condition="'$(Platform)' == 'arm64'" Include="-arch arm64" />
161-
<_MonoLDFLAGS Include="-Wl,-no_weak_imports" />
162+
<!--<_MonoLDFLAGS Include="-Wl,-no_weak_imports" />--> <!-- TODO: reenable once Xcode bug is fixed: https://github.com/mono/mono/issues/19393 -->
162163
<_MonoLDFLAGS Include="-Wl,-bitcode_bundle" />
163164
<_MonoLDFLAGS Include="-framework CoreFoundation" />
164165
<_MonoLDFLAGS Include="-lobjc" />
@@ -278,6 +279,7 @@
278279
<_MonoCFLAGS Condition="'$(Platform)' == 'arm'" Include="-arch armv7s" />
279280
<_MonoCFLAGS Include="-isysroot $(XcodeDir)/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS$(iOSVersion).sdk" />
280281
<_MonoCFLAGS Include="-miphoneos-version-min=$(iOSVersionMin)" />
282+
<_MonoCFLAGS Include="-Werror=partial-availability" />
281283
<_MonoCFLAGS Include="-Wl,-application_extension" />
282284
<_MonoCFLAGS Include="-fexceptions" />
283285

@@ -303,7 +305,7 @@
303305
<_MonoLDFLAGS Condition="'$(Platform)' == 'arm64'" Include="-arch arm64" />
304306
<_MonoLDFLAGS Condition="'$(Platform)' == 'arm'" Include="-arch armv7" />
305307
<_MonoLDFLAGS Condition="'$(Platform)' == 'arm'" Include="-arch armv7s" />
306-
<_MonoLDFLAGS Include="-Wl,-no_weak_imports" />
308+
<!--<_MonoLDFLAGS Include="-Wl,-no_weak_imports" />--> <!-- TODO: reenable once Xcode bug is fixed: https://github.com/mono/mono/issues/19393 -->
307309
<_MonoLDFLAGS Include="-framework CoreFoundation" />
308310
<_MonoLDFLAGS Include="-lobjc" />
309311
<_MonoLDFLAGS Include="-lc++" />

0 commit comments

Comments
 (0)