Skip to content

Fix analyzer RCS1198 #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 17, 2024
Merged

Fix analyzer RCS1198 #1501

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
92b961e
update
josefpihrt Aug 13, 2024
ae55cea
Merge branch 'main' into fix/rcs1198
josefpihrt Aug 17, 2024
9656ba9
Update src/Analyzers/CSharp/Analysis/AvoidBoxingOfValueTypeAnalyzer.cs
josefpihrt Aug 17, 2024
486d571
Update src/Tests/Analyzers.Tests/RCS1198AvoidBoxingOfValueTypeTests.cs
josefpihrt Aug 17, 2024
b000cde
changelog
josefpihrt Aug 17, 2024
a6aca73
Merge branch 'main' into fix/rcs1198
josefpihrt Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Analyzers/CSharp/Analysis/AvoidBoxingOfValueTypeAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,14 @@ public override void Initialize(AnalysisContext context)
{
base.Initialize(context);

context.RegisterSyntaxNodeAction(f => AnalyzeInterpolation(f), SyntaxKind.Interpolation);
context.RegisterCompilationStartAction(startContext =>
{
INamedTypeSymbol exceptionSymbol = startContext.Compilation.GetTypeByMetadataName("System.Runtime.CompilerServices.DefaultInterpolatedStringHandler");

if (exceptionSymbol is null)
startContext.RegisterSyntaxNodeAction(f => AnalyzeInterpolation(f), SyntaxKind.Interpolation);
});

}

private static void AnalyzeInterpolation(SyntaxNodeAnalysisContext context)
Expand Down
59 changes: 0 additions & 59 deletions src/Tests/Analyzers.Tests/RCS1198AvoidBoxingOfValueTypeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,65 +12,6 @@ public class RCS1198AvoidBoxingOfValueTypeTests : AbstractCSharpDiagnosticVerifi
{
public override DiagnosticDescriptor Descriptor { get; } = DiagnosticRules.AvoidBoxingOfValueType;

[Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.AvoidBoxingOfValueType)]
public async Task Test_Interpolation()
{
await VerifyDiagnosticAndFixAsync("""
using System;

class C
{
public TimeSpan P { get; }

void M()
{
var c = new C();

var x = $"{[|c?.P.TotalMilliseconds|]}";
}
}
""", """
using System;

class C
{
public TimeSpan P { get; }

void M()
{
var c = new C();

var x = $"{(c?.P.TotalMilliseconds).ToString()}";
}
}
""");
}

[Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.AvoidBoxingOfValueType)]
public async Task Test_Interpolation_NullableType()
{
await VerifyDiagnosticAndFixAsync("""
class C
{
void M()
{
int? i = null;

string s = $"{[|i|]}";
}
}
""", """
class C
{
void M()
{
int? i = null;

string s = $"{i?.ToString()}";
}
}
""");
}

// https://github.com/dotnet/roslyn/pull/35006
[Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.AvoidBoxingOfValueType)]
Expand Down