Merge pull request #63241 from CyrusNajmabadi/solutionServices

Make SolutionServices (and related) APIs public

Author: CyrusNajmabadi

src/Analyzers/CSharp/CodeFixes/InlineDeclaration/CSharpInlineDeclarationCodeFixProvider.cs

@@ -115,7 +115,7 @@ private static SyntaxNode ReplaceIdentifierWithInlineDeclaration(
             declarator = currentRoot.GetCurrentNode(declarator);
             identifier = currentRoot.GetCurrentNode(identifier);
 
-            var editor = document.GetSyntaxEditor(currentRoot);
+            var editor = new SyntaxEditor(currentRoot, document.Project.Solution.Services);
             var sourceText = currentRoot.GetText();
 
             var declaration = (VariableDeclarationSyntax)declarator.Parent;

src/Analyzers/CSharp/CodeFixes/NewLines/EmbeddedStatementPlacement/EmbeddedStatementPlacementCodeFixProvider.cs

@@ -48,7 +48,7 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
         public static async Task<Document> FixAllAsync(Document document, ImmutableArray<Diagnostic> diagnostics, CodeActionOptionsProvider codeActionOptionsProvider, CancellationToken cancellationToken)
         {
             var root = await document.GetRequiredSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
-            var editor = document.GetSyntaxEditor(root);
+            var editor = new SyntaxEditor(root, document.Project.Solution.Services);
 
             var options = await document.GetCSharpCodeFixOptionsProviderAsync(codeActionOptionsProvider, cancellationToken).ConfigureAwait(false);
 

src/Analyzers/CSharp/CodeFixes/RemoveConfusingSuppression/CSharpRemoveConfusingSuppressionCodeFixProvider.cs

@@ -64,7 +64,7 @@ private static async Task<Document> FixAllAsync(
         {
             var semanticModel = await document.GetRequiredSemanticModelAsync(cancellationToken).ConfigureAwait(false);
             var root = await document.GetRequiredSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
-            var editor = document.GetSyntaxEditor(root);
+            var editor = new SyntaxEditor(root, document.Project.Solution.Services);
             var generator = editor.Generator;
             var generatorInternal = document.GetRequiredLanguageService<SyntaxGeneratorInternal>();
 

src/Analyzers/CSharp/CodeFixes/UseDeconstruction/CSharpUseDeconstructionCodeFixProvider.cs

@@ -66,7 +66,7 @@ private SyntaxNode UpdateRoot(
             SyntaxNode node,
             CancellationToken cancellationToken)
         {
-            var editor = document.GetSyntaxEditor(root);
+            var editor = new SyntaxEditor(root, document.Project.Solution.Services);
 
             // We use the callback form of ReplaceNode because we may have nested code that
             // needs to be updated in fix-all situations.  For example, nested foreach statements.

src/Analyzers/Core/CodeFixes/RemoveUnusedParametersAndValues/AbstractRemoveUnusedValuesCodeFixProvider.cs

@@ -288,7 +288,7 @@ private async Task<SyntaxNode> GetNewRootAsync(
             var semanticFacts = document.GetRequiredLanguageService<ISemanticFactsService>();
             var semanticModel = await document.GetRequiredSemanticModelAsync(cancellationToken).ConfigureAwait(false);
 
-            var editor = document.GetSyntaxEditor(root);
+            var editor = new SyntaxEditor(root, document.Project.Solution.Services);
 
             // We compute the code fix in two passes:
             //   1. The first pass groups the diagnostics to fix by containing member declaration and

src/Analyzers/Core/CodeFixes/UnsealClass/AbstractUnsealClassCodeFixProvider.cs

@@ -65,7 +65,7 @@ private static async Task<Solution> UnsealDeclarationsAsync(
                 var document = solution.GetDocument(documentId);
                 var root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
 
-                var editor = document.GetSyntaxEditor(root);
+                var editor = new SyntaxEditor(root, document.Project.Solution.Services);
                 var generator = editor.Generator;
 
                 foreach (var syntaxReference in syntaxReferences)

src/Analyzers/Core/CodeFixes/UseCollectionInitializer/AbstractUseCollectionInitializerCodeFixProvider.cs

@@ -96,7 +96,7 @@ protected override async Task FixAllAsync(
                 var newStatement = GetNewStatement(statement, objectCreation, matches.Value)
                     .WithAdditionalAnnotations(Formatter.Annotation);
 
-                var subEditor = document.GetSyntaxEditor(currentRoot);
+                var subEditor = new SyntaxEditor(currentRoot, document.Project.Solution.Services);
 
                 subEditor.ReplaceNode(statement, newStatement);
                 foreach (var match in matches)

src/Analyzers/Core/CodeFixes/UseConditionalExpression/AbstractUseConditionalExpressionCodeFixProvider.cs

@@ -58,7 +58,7 @@ protected override async Task FixAllAsync(
             // will return 'true' if it made a multi-line conditional expression. In that case,
             // we'll need to explicitly format this node so we can get our special multi-line
             // formatting in VB and C#.
-            var nestedEditor = document.GetSyntaxEditor(root);
+            var nestedEditor = new SyntaxEditor(root, document.Project.Solution.Services);
             foreach (var diagnostic in diagnostics)
             {
                 await FixOneAsync(

src/Analyzers/Core/CodeFixes/UseObjectInitializer/AbstractUseObjectInitializerCodeFixProvider.cs

@@ -97,7 +97,7 @@ protected override async Task FixAllAsync(
                 var newStatement = GetNewStatement(statement, objectCreation, matches.Value)
                     .WithAdditionalAnnotations(Formatter.Annotation);
 
-                var subEditor = document.GetSyntaxEditor(currentRoot);
+                var subEditor = new SyntaxEditor(currentRoot, document.Project.Solution.Services);
 
                 subEditor.ReplaceNode(statement, newStatement);
                 foreach (var match in matches)

src/Analyzers/VisualBasic/CodeFixes/RemoveUnnecessaryCast/VisualBasicRemoveUnnecessaryCastCodeFixProvider.vb

@@ -100,7 +100,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.RemoveUnnecessaryCast
             ' Now, find the cast nodes again in the expanded document
             Dim currentCastNodes = root.GetCurrentNodes(originalCastNodes)
 
-            Dim innerEditor = document.GetSyntaxEditor(root)
+            Dim innerEditor = New SyntaxEditor(root, document.Project.Solution.Services)
             Await innerEditor.ApplyExpressionLevelSemanticEditsAsync(
                 document, currentCastNodes.ToImmutableArray(),
                 Function(semanticModel, castExpression) IsUnnecessaryCast(castExpression, semanticModel, cancellationToken),
@@ -134,7 +134,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.RemoveUnnecessaryCast
                         {containingStatement, nextStatement})
                 End Function).Distinct()
 
-            Dim editor = document.GetSyntaxEditor(root)
+            Dim editor = New SyntaxEditor(root, document.Project.Solution.Services)
 
             For Each containingStatement In containingAndNextStatements
                 Dim expandedStatement = Await Simplifier.ExpandAsync(containingStatement, document, cancellationToken:=cancellationToken).ConfigureAwait(False)