Add separate DeserializePacket() to INodePacketFactory #11650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccastanedaucf
force-pushed
the
dev/chcasta/ipc-cleanup-1
branch
from
b496ac9 to
def23c9
Compare
YuliiaKovalova
approved these changes
Apr 2, 2025
JanProvaznik
reviewed
Apr 3, 2025
JanProvaznik
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Minimum change to get shared IPC added in #11546 recompiling again for #11383 (since the original PR was reverted).
Changes Made
DeserializeAndRoutePacket()inPacketFactoryRecord(private class)DeserializePacket()toINodePacketFactoryand all implementations. Does not remove old method.No behavior changes to MSBuild.