Repository navigation
Commit 21b1ec7
Dreaming: enforce reviewer intersection (discussion participant AND kitten member) (#14383)
## Context: validating the reviewers + multi-PR change
After #14373 merged, I triggered a live Dreaming run
([29432875878](https://github.com/dotnet/msbuild/actions/runs/29432875878))
to validate the new behavior. Results:
- ✅ **Multi-PR worked** — the run opened **two atomic PRs**, each
touching a single file with a distinct theme (#14381 logging
instructions, #14382 expert-reviewer agent). Exactly the intended
one-pattern-per-PR shape.
- ✅ **Reviewer section rendered** on both, with the softened "please
assign" wording.
- ❌ **One reviewer was wrong.** #14382 listed `@baronfel`, who is
**not** on the `@dotnet/kitten` roster (`gh api
orgs/dotnet/teams/kitten/memberships/baronfel` → 404) **and** was not in
that PR's cited discussion (only `@jankratochvilcz` was). The agent
invented a plausible-sounding name instead of strictly filtering.
(#14381's `@rainersigwald` was correct — active kitten member and the
actual reviewer.)
## Fix
Tighten Step 5b so a reviewer qualifies **only if the login is in
BOTH**:
1. the fetched `orgs/dotnet/teams/kitten/members` output, **and**
2. that pattern's actual discussion-participant list.
Plus explicit guardrails:
- **Never** add a name from memory / general knowledge of "who works on
MSBuild" / because it seems plausible.
- A **pre-emit self-check**: before emitting each PR, verify every
`@`-mention on the reviewers line is in both lists; drop any that fail.
- When in doubt, prefer the `@dotnet/kitten` fallback over guessing an
individual.
## Scope
Only the Dreaming workflow prompt + recompiled lock (1-line lock change:
the embedded prompt hash/text). Compiles clean (0/0). This directly
closes the gap the validation run exposed.
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jankratochvilcz <2202487+jankratochvilcz@users.noreply.github.com>1 parent 6fd50b8 commit 21b1ec7
2 files changed
Lines changed: 93 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
253 | 253 | | |
254 | 254 | | |
255 | 255 | | |
256 | | - | |
| 256 | + | |
257 | 257 | | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
263 | 271 | | |
264 | 272 | | |
265 | 273 | | |
| |||
276 | 284 | | |
277 | 285 | | |
278 | 286 | | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
279 | 293 | | |
280 | 294 | | |
281 | 295 | | |
| |||
0 commit comments