Skip to content

Commit 11ea51a

Browse files
committed
Move code to individual handlers
1 parent 15ddfaf commit 11ea51a

9 files changed

Lines changed: 17 additions & 15 deletions

File tree

src/Core/src/Handlers/Button/ButtonHandler.Windows.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,5 +130,7 @@ public override void SetImageSource(ImageSource? platformImage)
130130
button.UpdateImageSource(platformImage);
131131
}
132132
}
133+
134+
internal override bool PreventGestureBubbling => true;
133135
}
134136
}

src/Core/src/Handlers/DatePicker/DatePickerHandler.Windows.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,5 +85,7 @@ public static partial void MapBackground(IDatePickerHandler handler, IDatePicker
8585
{
8686
handler.PlatformView?.UpdateBackground(datePicker);
8787
}
88+
89+
internal override bool PreventGestureBubbling => true;
8890
}
8991
}

src/Core/src/Handlers/ImageButton/ImageButtonHandler.Windows.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,5 +147,7 @@ public override void SetImageSource(ImageSource? platformImage)
147147
button.UpdateImageSource(platformImage);
148148
}
149149
}
150+
151+
internal override bool PreventGestureBubbling => true;
150152
}
151153
}

src/Core/src/Handlers/RadioButton/RadioButtonHandler.Windows.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,5 +71,7 @@ void OnCheckedOrUnchecked(object? sender, RoutedEventArgs e)
7171

7272
VirtualView.IsChecked = PlatformView.IsChecked == true;
7373
}
74+
75+
internal override bool PreventGestureBubbling => true;
7476
}
7577
}

src/Core/src/Handlers/Slider/SliderHandler.Windows.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,5 +121,7 @@ void OnPointerReleased(object? sender, PointerRoutedEventArgs e)
121121
{
122122
VirtualView?.DragCompleted();
123123
}
124+
125+
internal override bool PreventGestureBubbling => true;
124126
}
125127
}

src/Core/src/Handlers/Stepper/StepperHandler.Windows.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,7 @@ void OnValueChanged(object sender, EventArgs e)
5454

5555
VirtualView.Value = PlatformView.Value;
5656
}
57+
58+
internal override bool PreventGestureBubbling => true;
5759
}
5860
}

src/Core/src/Handlers/Switch/SwitchHandler.Windows.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,7 @@ void OnToggled(object sender, UI.Xaml.RoutedEventArgs e)
4343

4444
VirtualView.IsOn = PlatformView.IsOn;
4545
}
46+
47+
internal override bool PreventGestureBubbling => true;
4648
}
4749
}

src/Core/src/Handlers/TimePicker/TimePickerHandler.Windows.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,7 @@ void OnControlTimeChanged(object? sender, TimePickerValueChangedEventArgs e)
5959
VirtualView.InvalidateMeasure();
6060
}
6161
}
62+
63+
internal override bool PreventGestureBubbling => true;
6264
}
6365
}

src/Core/src/Handlers/View/ViewHandler.Windows.cs

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -170,20 +170,6 @@ void UpdateIsFocused(bool isFocused)
170170
}
171171
}
172172

173-
// TODO is it a good idea to have virtual methods for one specific platform?
174-
// TODO move the switch to the control handlers' overrides
175-
internal virtual bool PreventGestureBubbling
176-
=> this switch
177-
{
178-
Button => true,
179-
DatePicker => true,
180-
Stepper => true,
181-
Slider => true,
182-
Switch => true,
183-
TimePicker => true,
184-
ImageButton => true,
185-
RadioButton => true,
186-
_ => false,
187-
};
173+
internal virtual bool PreventGestureBubbling => false;
188174
}
189175
}

0 commit comments

Comments
 (0)