-
Notifications
You must be signed in to change notification settings - Fork 2k
Expand file tree
/
Copy pathRelativeSourceBindings.cs
More file actions
405 lines (338 loc) · 11.8 KB
/
RelativeSourceBindings.cs
File metadata and controls
405 lines (338 loc) · 11.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
using System;
using System.IO;
using System.Linq;
using Xunit;
namespace Microsoft.Maui.Controls.SourceGen.UnitTests;
public class RelativeSourceBindings : SourceGenXamlInitializeComponentTestBase
{
[Fact]
public void FindAncestorBindingContextGeneratesValidCode()
{
var xaml =
"""
<?xml version="1.0" encoding="UTF-8"?>
<ContentPage
xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
xmlns:test="clr-namespace:Test"
x:Class="Test.TestPage">
<StackLayout>
<StackLayout.BindingContext>
<test:TestViewModel />
</StackLayout.BindingContext>
<StackLayout BindingContext="{x:Null}">
<Label Text="{Binding Path=Name, Source={RelativeSource AncestorType={x:Type test:TestViewModel}, Mode=FindAncestorBindingContext}}" />
</StackLayout>
</StackLayout>
</ContentPage>
""";
var code =
"""
#nullable enable
using Microsoft.Maui.Controls;
using Microsoft.Maui.Controls.Xaml;
namespace Test;
[XamlProcessing(XamlInflator.SourceGen)]
public partial class TestPage : ContentPage
{
public TestPage()
{
InitializeComponent();
}
}
public class TestViewModel
{
public string Name => "TestName";
}
""";
var (result, generated) = RunGenerator(xaml, code);
// Verify no diagnostics
Assert.False(result.Diagnostics.Any(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error),
$"Generator produced errors: {string.Join(", ", result.Diagnostics.Where(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error).Select(d => d.GetMessage()))}");
// Verify generated code exists
Assert.NotNull(generated);
// Verify that XamlTypeResolver is NOT used (would produce trimming and AOT warnings)
Assert.DoesNotContain("XamlTypeResolver", generated, StringComparison.Ordinal);
// Verify RelativeBindingSource is generated correctly
Assert.Contains("RelativeBindingSource", generated, StringComparison.Ordinal);
Assert.Contains("FindAncestorBindingContext", generated, StringComparison.Ordinal);
}
[Fact]
public void FindAncestorGeneratesValidCode()
{
var xaml =
"""
<?xml version="1.0" encoding="UTF-8"?>
<ContentPage
xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
x:Class="Test.TestPage">
<StackLayout x:Name="Stack1" StyleId="TestStack">
<Label Text="{Binding Path=StyleId, Source={RelativeSource AncestorType={x:Type StackLayout}}}" />
</StackLayout>
</ContentPage>
""";
var code =
"""
#nullable enable
using Microsoft.Maui.Controls;
using Microsoft.Maui.Controls.Xaml;
namespace Test;
[XamlProcessing(XamlInflator.SourceGen)]
public partial class TestPage : ContentPage
{
public TestPage()
{
InitializeComponent();
}
}
""";
var (result, generated) = RunGenerator(xaml, code);
// Verify no diagnostics
Assert.False(result.Diagnostics.Any(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error),
$"Generator produced errors: {string.Join(", ", result.Diagnostics.Where(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error).Select(d => d.GetMessage()))}");
// Verify generated code exists
Assert.NotNull(generated);
// Verify that XamlTypeResolver is NOT used (would produce trimming and AOT warnings)
Assert.DoesNotContain("XamlTypeResolver", generated, StringComparison.Ordinal);
// Verify RelativeBindingSource is generated correctly
Assert.Contains("RelativeBindingSource", generated, StringComparison.Ordinal);
Assert.Contains("FindAncestor", generated, StringComparison.Ordinal);
}
[Fact]
public void SelfBindingGeneratesValidCode()
{
var xaml =
"""
<?xml version="1.0" encoding="UTF-8"?>
<ContentPage
xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
x:Class="Test.TestPage">
<Label StyleId="SelfTest" Text="{Binding Path=StyleId, Source={RelativeSource Self}}" />
</ContentPage>
""";
var code =
"""
#nullable enable
using Microsoft.Maui.Controls;
using Microsoft.Maui.Controls.Xaml;
namespace Test;
[XamlProcessing(XamlInflator.SourceGen)]
public partial class TestPage : ContentPage
{
public TestPage()
{
InitializeComponent();
}
}
""";
var (result, generated) = RunGenerator(xaml, code);
// Verify no diagnostics
Assert.False(result.Diagnostics.Any(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error),
$"Generator produced errors: {string.Join(", ", result.Diagnostics.Where(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error).Select(d => d.GetMessage()))}");
// Verify generated code exists
Assert.NotNull(generated);
// Verify that XamlTypeResolver is NOT used (would produce trimming and AOT warnings)
Assert.DoesNotContain("XamlTypeResolver", generated, StringComparison.Ordinal);
// Verify RelativeBindingSource.Self is generated correctly
Assert.Contains("RelativeBindingSource.Self", generated, StringComparison.Ordinal);
}
[Fact]
public void TemplatedParentBindingGeneratesValidCode()
{
var xaml =
"""
<?xml version="1.0" encoding="UTF-8"?>
<ContentPage
xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
x:Class="Test.TestPage">
<ContentPage.Resources>
<ControlTemplate x:Key="TestTemplate">
<Label Text="{Binding Source={RelativeSource TemplatedParent}, Path=StyleId}" />
</ControlTemplate>
</ContentPage.Resources>
</ContentPage>
""";
var code =
"""
#nullable enable
using Microsoft.Maui.Controls;
using Microsoft.Maui.Controls.Xaml;
namespace Test;
[XamlProcessing(XamlInflator.SourceGen)]
public partial class TestPage : ContentPage
{
public TestPage()
{
InitializeComponent();
}
}
""";
var (result, generated) = RunGenerator(xaml, code);
// Verify no diagnostics
Assert.False(result.Diagnostics.Any(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error),
$"Generator produced errors: {string.Join(", ", result.Diagnostics.Where(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error).Select(d => d.GetMessage()))}");
// Verify generated code exists
Assert.NotNull(generated);
// Verify that XamlTypeResolver is NOT used (would produce trimming and AOT warnings)
Assert.DoesNotContain("XamlTypeResolver", generated, StringComparison.Ordinal);
// Verify RelativeBindingSource.TemplatedParent is generated correctly
Assert.Contains("RelativeBindingSource.TemplatedParent", generated, StringComparison.Ordinal);
}
[Fact]
public void ImplicitModeInferenceGeneratesValidCode()
{
// When AncestorType is a non-Element type and Mode is not specified,
// FindAncestorBindingContext should be inferred
var xaml =
"""
<?xml version="1.0" encoding="UTF-8"?>
<ContentPage
xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
xmlns:test="clr-namespace:Test"
x:Class="Test.TestPage">
<StackLayout>
<StackLayout.BindingContext>
<test:TestViewModel />
</StackLayout.BindingContext>
<Label Text="{Binding Source={RelativeSource AncestorType={x:Type test:TestViewModel}}, Path=Name}" />
</StackLayout>
</ContentPage>
""";
var code =
"""
#nullable enable
using Microsoft.Maui.Controls;
using Microsoft.Maui.Controls.Xaml;
namespace Test;
[XamlProcessing(XamlInflator.SourceGen)]
public partial class TestPage : ContentPage
{
public TestPage()
{
InitializeComponent();
}
}
public class TestViewModel
{
public string Name => "TestName";
}
""";
var (result, generated) = RunGenerator(xaml, code);
// Verify no diagnostics
Assert.False(result.Diagnostics.Any(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error),
$"Generator produced errors: {string.Join(", ", result.Diagnostics.Where(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error).Select(d => d.GetMessage()))}");
// Verify generated code exists
Assert.NotNull(generated);
// Verify that XamlTypeResolver is NOT used (would produce trimming and AOT warnings)
Assert.DoesNotContain("XamlTypeResolver", generated, StringComparison.Ordinal);
// Verify RelativeBindingSource is generated with FindAncestorBindingContext (inferred from non-Element type)
Assert.Contains("RelativeBindingSource", generated, StringComparison.Ordinal);
Assert.Contains("FindAncestorBindingContext", generated, StringComparison.Ordinal);
}
[Fact]
public void SelfPathWithFindAncestorGeneratesValidCode()
{
// Test for regression: RelativeSource AncestorType with Path=. should return the ancestor itself
var xaml =
"""
<?xml version="1.0" encoding="UTF-8"?>
<ContentPage
xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
x:Class="Test.TestPage">
<Grid>
<Grid.GestureRecognizers>
<TapGestureRecognizer Command="{Binding Navigate}"
CommandParameter="{Binding Path=., Source={RelativeSource AncestorType={x:Type ContentPage}}}" />
</Grid.GestureRecognizers>
</Grid>
</ContentPage>
""";
var code =
"""
#nullable enable
using System.Windows.Input;
using Microsoft.Maui.Controls;
using Microsoft.Maui.Controls.Xaml;
namespace Test;
[XamlProcessing(XamlInflator.SourceGen)]
public partial class TestPage : ContentPage
{
public TestPage()
{
InitializeComponent();
BindingContext = this;
}
public ICommand Navigate => new Command((param) => { });
}
""";
var (result, generated) = RunGenerator(xaml, code);
// Verify no diagnostics
Assert.False(result.Diagnostics.Any(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error),
$"Generator produced errors: {string.Join(", ", result.Diagnostics.Where(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error).Select(d => d.GetMessage()))}");
// Verify generated code exists
Assert.NotNull(generated);
// Verify RelativeBindingSource is generated correctly with FindAncestor mode (ContentPage is an Element)
Assert.Contains("RelativeBindingSource", generated, StringComparison.Ordinal);
Assert.Contains("FindAncestor", generated, StringComparison.Ordinal);
Assert.Contains("ContentPage", generated, StringComparison.Ordinal);
}
[Fact]
public void SelfPathWithFindAncestorCustomTypeGeneratesValidCode()
{
// Test for regression: RelativeSource AncestorType with Path=. and custom page type
// This replicates the user's scenario where MainPage is a custom type
var xaml =
"""
<?xml version="1.0" encoding="UTF-8"?>
<ContentView
xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
xmlns:test="clr-namespace:Test"
x:Class="Test.ChildView"
x:DataType="test:ChildView">
<Grid>
<Grid.GestureRecognizers>
<TapGestureRecognizer Command="{Binding Navigate}"
CommandParameter="{Binding Path=., Source={RelativeSource AncestorType={x:Type test:MainPage}}}" />
</Grid.GestureRecognizers>
</Grid>
</ContentView>
""";
var code =
"""
#nullable enable
using System.Windows.Input;
using Microsoft.Maui.Controls;
using Microsoft.Maui.Controls.Xaml;
namespace Test;
[XamlProcessing(XamlInflator.SourceGen)]
public partial class ChildView : ContentView
{
public ChildView()
{
InitializeComponent();
BindingContext = this;
}
public ICommand Navigate => new Command((param) => { });
}
public class MainPage : ContentPage
{
}
""";
var (result, generated) = RunGenerator(xaml, code);
// Verify no diagnostics
Assert.False(result.Diagnostics.Any(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error),
$"Generator produced errors: {string.Join(", ", result.Diagnostics.Where(d => d.Severity == Microsoft.CodeAnalysis.DiagnosticSeverity.Error).Select(d => d.GetMessage()))}");
// Verify generated code exists
Assert.NotNull(generated);
// Verify RelativeBindingSource is generated correctly with FindAncestor mode and custom type
Assert.Contains("RelativeBindingSource", generated, StringComparison.Ordinal);
Assert.Contains("FindAncestor", generated, StringComparison.Ordinal);
Assert.Contains("Test.MainPage", generated, StringComparison.Ordinal);
}
}