Skip to content

Commit b6effee

Browse files
Copilotrolfbjarne
andcommitted
Address final review feedback: update docs, add dependency, sort properties
Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>
1 parent 82285a0 commit b6effee

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

docs/building-apps/build-properties.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,12 +287,11 @@ This computed instruction set is then passed to crossgen2 via the `--instruction
287287

288288
Set this property to `false` to disable automatic instruction set computation and use crossgen2's default behavior.
289289

290-
Default: `true` (when `PublishReadyToRun` is enabled)
290+
Default: `true`
291291

292292
Example:
293293
```xml
294294
<PropertyGroup>
295-
<PublishReadyToRun>true</PublishReadyToRun>
296295
<ComputeInstructionSetForReadyToRun>false</ComputeInstructionSetForReadyToRun>
297296
</PropertyGroup>
298297
```

dotnet/targets/Microsoft.Sdk.R2R.targets

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
-->
1010
<Target Name="_ComputeInstructionSetForCrossgen2"
1111
Condition="'$(PublishReadyToRun)' == 'true' And '$(ComputeInstructionSetForReadyToRun)' != 'false'"
12+
DependsOnTargets="_DetectSdkLocations"
1213
BeforeTargets="ResolveReadyToRunCompilers">
1314
<ComputeInstructionSet
1415
RuntimeIdentifier="$(RuntimeIdentifier)"

msbuild/Xamarin.MacDev.Tasks/Tasks/ComputeInstructionSet.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ public class ComputeInstructionSet : XamarinTask {
1616
#region Inputs
1717

1818
[Required]
19-
public string SupportedOSPlatformVersion { get; set; } = "";
19+
public string RuntimeIdentifier { get; set; } = "";
2020

2121
[Required]
22-
public string RuntimeIdentifier { get; set; } = "";
22+
public string SupportedOSPlatformVersion { get; set; } = "";
2323

2424
#endregion
2525

0 commit comments

Comments
 (0)