Repository navigation
Commit e74989f
committed
Revert the IlxGen.fs list-creation micro-optimization
ILVerify flags FSharp.Compiler.IlxGen::HashRangeSorted with a
StackUnexpected error in Release builds on this branch that does not
match the checked-in baseline, even though the exact same error text
is already present in that baseline as a known pre-existing issue.
Isolating the change (including testing byte-identical origin/main
source through the same local Release build) could not reproduce a
difference tied to this commit's content, but the CI-observed mismatch
persisted across a partial revert. The allocation savings here are
marginal; not worth risking invalid IL in a shipped compiler DLL over,
so this reverts to the original List-based HashRangeSorted and the
original `@` concatenations in TypeDefBuilder.Close and GenTypeDef.1 parent 56aa82e commit e74989f
2 files changed
Lines changed: 5 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
194 | | - | |
195 | 194 | | |
196 | 195 | | |
197 | 196 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1972 | 1972 | | |
1973 | 1973 | | |
1974 | 1974 | | |
1975 | | - | |
| 1975 | + | |
1976 | 1976 | | |
1977 | 1977 | | |
1978 | 1978 | | |
| |||
2075 | 2075 | | |
2076 | 2076 | | |
2077 | 2077 | | |
2078 | | - | |
| 2078 | + | |
2079 | 2079 | | |
2080 | | - | |
| 2080 | + | |
2081 | 2081 | | |
2082 | 2082 | | |
2083 | 2083 | | |
| |||
12291 | 12291 | | |
12292 | 12292 | | |
12293 | 12293 | | |
12294 | | - | |
12295 | | - | |
12296 | | - | |
12297 | | - | |
12298 | | - | |
12299 | | - | |
12300 | | - | |
12301 | | - | |
12302 | | - | |
12303 | | - | |
| 12294 | + | |
| 12295 | + | |
12304 | 12296 | | |
12305 | 12297 | | |
12306 | 12298 | | |
| |||
0 commit comments